From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UP9mr-0004vc-5R
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 06:59:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UP9mn-0003HI-Eo
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 06:58:57 -0400
Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:38900)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UP9mn-0003Gu-5O
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 06:58:53 -0400
Received: by mail-we0-f182.google.com with SMTP id k14so4387627wer.41
	for <qemu-devel@nongnu.org>; Mon, 08 Apr 2013 03:58:52 -0700 (PDT)
Date: Mon, 8 Apr 2013 12:58:49 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130408105849.GD12076@stefanha-thinkpad.redhat.com>
References: <1363283830-22717-1-git-send-email-peter.maydell@linaro.org>
	<1363283830-22717-3-git-send-email-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1363283830-22717-3-git-send-email-peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] configure: Don't fall back to
 gthread coroutine backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, patches@linaro.org

On Thu, Mar 14, 2013 at 05:57:10PM +0000, Peter Maydell wrote:
> -block-obj-$(CONFIG_WIN32) += coroutine-win32.o

"win32"

> +block-obj-y += coroutine-$(CONFIG_COROUTINE_BACKEND).o

...backend name expanded into object file name...

> +if test "$coroutine" = ""; then
> +  if test "$mingw32" = "yes"; then
> +    coroutine=windows

"windows"

Please change "windows" to "win32" so the Windows build works.

Stefan