From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48334)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UPAOG-0007P3-TJ
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 07:37:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UPAOB-0000p6-Ti
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 07:37:36 -0400
Received: from mail-wg0-f45.google.com ([74.125.82.45]:35402)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UPAOB-0000p0-OO
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 07:37:31 -0400
Received: by mail-wg0-f45.google.com with SMTP id x12so5765737wgg.12
	for <qemu-devel@nongnu.org>; Mon, 08 Apr 2013 04:37:31 -0700 (PDT)
Date: Mon, 8 Apr 2013 13:37:28 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130408113728.GD12852@stefanha-thinkpad.redhat.com>
References: <1364399849-5518-1-git-send-email-rjones@redhat.com>
	<1364399849-5518-2-git-send-email-rjones@redhat.com>
	<20130328104732.GA15114@stefanha-thinkpad.redhat.com>
	<20130403221430.GA1464@rhmail.home.annexia.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130403221430.GA1464@rhmail.home.annexia.org>
Subject: Re: [Qemu-devel] [PATCH v4] block: Add support for Secure Shell
 (ssh) block device.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Apr 03, 2013 at 11:14:30PM +0100, Richard W.M. Jones wrote:
> On Thu, Mar 28, 2013 at 11:47:32AM +0100, Stefan Hajnoczi wrote:
> > On Wed, Mar 27, 2013 at 03:57:29PM +0000, Richard W.M. Jones wrote:
> > Please run qemu-iotests, see tests/qemu-iotests/check.  For example,
> > with NBD:
> > 
> >   $ cd tests/qemu-iotests
> >   $ QEMU_PROG=$HOME/qemu/x86_64-softmmu/qemu-system-x86_64 PATH=$HOME/qemu:$PATH \
> >     ./check -nbd
> > 
> > A patch will be required to add -ssh support to ./check.
> 
> I have added this in the updated patch.
> 
> A question: Are the -qcow2 tests meant to pass?  Many don't pass for
> my ssh driver (ie. './check -ssh -qcow2').  I tried using the nbd
> driver (ie. './check -nbd -qcow2') and a large number of those fail as
> well.  To take an example, test 013 fails because it tries to run the
> 'mv' command on the nbd: URL (or the ssh: URL when running the test on
> my block driver).  It looks like this and other qcow2 tests are a bit
> broken on anything other than plain files.

Yes, I don't expect qemu-iotests to work with qcow2-on-nbd.

Just ./check -nbd and ./check -ssh should work.

Stefan