From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPCLx-00069n-T7 for qemu-devel@nongnu.org; Mon, 08 Apr 2013 09:43:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPCLs-0008Tz-2u for qemu-devel@nongnu.org; Mon, 08 Apr 2013 09:43:21 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:38894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPCLr-0008Te-TT for qemu-devel@nongnu.org; Mon, 08 Apr 2013 09:43:16 -0400 Received: by mail-wg0-f51.google.com with SMTP id b12so5897699wgh.30 for ; Mon, 08 Apr 2013 06:43:15 -0700 (PDT) Date: Mon, 8 Apr 2013 15:43:12 +0200 From: Stefan Hajnoczi Message-ID: <20130408134312.GD4429@stefanha-thinkpad.redhat.com> References: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1364903250-10429-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snapshot info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com On Tue, Apr 02, 2013 at 07:47:13PM +0800, Wenchao Xia wrote: > In the use of snapshot a way to retrieve related info at runtime is needed, > so this serial of patches will merge some code for qemu and qemu-img, and add > or enchance following interfaces for qemu: Looks pretty good, I commented on a few small things. Stefan