From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56730)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UPE03-000250-KD
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 11:28:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UPDzx-0002RV-Do
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 11:28:51 -0400
Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:60309)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UPDzx-0002RN-7o
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 11:28:45 -0400
Received: by mail-wg0-f41.google.com with SMTP id y10so3879845wgg.4
	for <qemu-devel@nongnu.org>; Mon, 08 Apr 2013 08:28:44 -0700 (PDT)
Date: Mon, 8 Apr 2013 17:28:41 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130408152841.GA22660@stefanha-thinkpad.redhat.com>
References: <1364507550-25093-1-git-send-email-aliguori@us.ibm.com>
	<1364507550-25093-2-git-send-email-aliguori@us.ibm.com>
	<5154D42E.70804@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5154D42E.70804@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 1/3] aio-context: if io_flush isn't
 provided, assume "always busy"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Mike Roth <mdroth@linux.vnet.ibm.com>

On Fri, Mar 29, 2013 at 12:37:18AM +0100, Paolo Bonzini wrote:
> Il 28/03/2013 22:52, Anthony Liguori ha scritto:
> > Today, all callers of qemu_aio_set_fd_handler() pass a valid io_flush
> > function.
> 
> Except one:
> 
>     aio_set_event_notifier(ctx, &ctx->notifier,
>                            (EventNotifierHandler *)
>                            event_notifier_test_and_clear, NULL);
> 
> This is the EventNotifier that is used by qemu_notify_event.
> 
> It's quite surprising that this patch works and passes the tests. /me
> reads cover letter... ah, it is untested. :)

This one instance is easy enough to fix by a return 0 io_flush handler.

Stefan