From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] block: Vectored bdrv_writev_vmstate
Date: Tue, 9 Apr 2013 10:30:45 +0200 [thread overview]
Message-ID: <20130409083045.GA5417@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <5163CC76.3000204@redhat.com>
On Tue, Apr 09, 2013 at 10:08:22AM +0200, Paolo Bonzini wrote:
> Il 09/04/2013 10:04, Kevin Wolf ha scritto:
> >> >
> >> > Looks good, but given there are patches to fix it, I'm not sure it's
> >> > worth the trouble...
> > Shouldn't this perform even a little better? And we should get rid of
> > non-vectored interfaces in the block layer anyway.
>
> Yes, if you have a very fast disk it should. Network throughput with
> Orit's patches jumped from 2.9 Gbps to 4.2 Gbps. But savevm is not
> live, so it is not as important to make it really fast.
Users have been asking about poor savevm/loadvm performance recently. I
think anything we can do it improve it, especially since these patches
already exist, is good.
Stefan
next prev parent reply other threads:[~2013-04-09 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 19:27 [Qemu-devel] [PATCH 0/4] block: Vectored bdrv_writev_vmstate Kevin Wolf
2013-04-05 19:27 ` [Qemu-devel] [PATCH 1/4] block: Introduce bdrv_writev_vmstate Kevin Wolf
2013-04-05 19:27 ` [Qemu-devel] [PATCH 2/4] savevm: Implement block_writev_buffer() Kevin Wolf
2013-04-05 19:27 ` [Qemu-devel] [PATCH 3/4] block: Introduce bdrv_pwritev() for qcow2_save_vmstate Kevin Wolf
2013-04-05 19:27 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: A few more bdrv_pread/pwrite tests Kevin Wolf
2013-04-08 16:03 ` [Qemu-devel] [PATCH 0/4] block: Vectored bdrv_writev_vmstate Stefan Hajnoczi
2013-04-08 16:18 ` Paolo Bonzini
2013-04-09 8:04 ` Kevin Wolf
2013-04-09 8:08 ` Paolo Bonzini
2013-04-09 8:30 ` Stefan Hajnoczi [this message]
2013-04-09 12:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409083045.GA5417@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).