From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPTx6-0004LE-7p for qemu-devel@nongnu.org; Tue, 09 Apr 2013 04:30:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPTx3-0003HL-7O for qemu-devel@nongnu.org; Tue, 09 Apr 2013 04:30:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPTx2-0003HC-Kx for qemu-devel@nongnu.org; Tue, 09 Apr 2013 04:30:49 -0400 Date: Tue, 9 Apr 2013 10:30:45 +0200 From: Stefan Hajnoczi Message-ID: <20130409083045.GA5417@stefanha-thinkpad.redhat.com> References: <1365190076-20268-1-git-send-email-kwolf@redhat.com> <20130408160319.GE22660@stefanha-thinkpad.redhat.com> <5162EDD2.1030304@redhat.com> <20130409080438.GA2922@dhcp-200-207.str.redhat.com> <5163CC76.3000204@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5163CC76.3000204@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/4] block: Vectored bdrv_writev_vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Stefan Hajnoczi , qemu-devel@nongnu.org On Tue, Apr 09, 2013 at 10:08:22AM +0200, Paolo Bonzini wrote: > Il 09/04/2013 10:04, Kevin Wolf ha scritto: > >> > > >> > Looks good, but given there are patches to fix it, I'm not sure it's > >> > worth the trouble... > > Shouldn't this perform even a little better? And we should get rid of > > non-vectored interfaces in the block layer anyway. > > Yes, if you have a very fast disk it should. Network throughput with > Orit's patches jumped from 2.9 Gbps to 4.2 Gbps. But savevm is not > live, so it is not as important to make it really fast. Users have been asking about poor savevm/loadvm performance recently. I think anything we can do it improve it, especially since these patches already exist, is good. Stefan