From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52299)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UPXon-0000mB-My
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:38:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UPXom-00089W-35
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:38:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48156)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UPXol-00089P-PY
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:38:32 -0400
Date: Tue, 9 Apr 2013 08:38:21 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130409083821.07e74699@redhat.com>
In-Reply-To: <20130409030215.GD19067@localhost.localdomain>
References: <1364240439-23450-1-git-send-email-lcapitulino@redhat.com>
	<1364240439-23450-2-git-send-email-lcapitulino@redhat.com>
	<20130409030215.GD19067@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] qstring: add qobject_get_length()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: fred.konrad@greensocs.com, qemu-devel@nongnu.org, kraxel@redhat.com

On Tue, 9 Apr 2013 11:02:15 +0800
Hu Tao <hutao@cn.fujitsu.com> wrote:

> 'add qobject_get_length()' in the subject line but you are actually
> adding qstring_get_length()

Thanks, but this was corrected in v2 and it's what got merged.

> 
> On Mon, Mar 25, 2013 at 03:40:38PM -0400, Luiz Capitulino wrote:
> > Long overdue.
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  include/qapi/qmp/qstring.h | 1 +
> >  qobject/qstring.c          | 8 ++++++++
> >  2 files changed, 9 insertions(+)
> > 
> > diff --git a/include/qapi/qmp/qstring.h b/include/qapi/qmp/qstring.h
> > index 0e690f4..1bc3666 100644
> > --- a/include/qapi/qmp/qstring.h
> > +++ b/include/qapi/qmp/qstring.h
> > @@ -26,6 +26,7 @@ typedef struct QString {
> >  QString *qstring_new(void);
> >  QString *qstring_from_str(const char *str);
> >  QString *qstring_from_substr(const char *str, int start, int end);
> > +size_t qstring_get_length(const QString *qstring);
> >  const char *qstring_get_str(const QString *qstring);
> >  void qstring_append_int(QString *qstring, int64_t value);
> >  void qstring_append(QString *qstring, const char *str);
> > diff --git a/qobject/qstring.c b/qobject/qstring.c
> > index 5f7376c..607b7a1 100644
> > --- a/qobject/qstring.c
> > +++ b/qobject/qstring.c
> > @@ -32,6 +32,14 @@ QString *qstring_new(void)
> >  }
> >  
> >  /**
> > + * qstring_get_length(): Get the length of a QString
> > + */
> > +size_t qstring_get_length(const QString *qstring)
> > +{
> > +    return qstring->length;
> > +}
> > +
> > +/**
> >   * qstring_from_substr(): Create a new QString from a C string substring
> >   *
> >   * Return string reference
> > -- 
> > 1.8.1.4
>