Re: [Qemu-devel] [RFC PATCH 1/8] qtest: add libqos

[Kevin Wolf <kwolf@redhat.com>]

Am 29.03.2013 um 03:26 hat Anthony Liguori geschrieben:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
> > Am 13.03.2013 um 15:03 hat Anthony Liguori geschrieben:
> >> You are correct, it should look something like:
> >> 
> >> if (addr & PCI_BASE_ADDRESS_SPACE_IO) {
> >>     size = (1ULL << ctzl(addr & PCI_BASE_ADDRESS_IO_MASK));
> >> } else {
> >>     size = (1ULL << ctzl(addr & PCI_BASE_ADDRESS_MEM_MASK));
> >> }
> >> 
> >> This doesn't deal with 64-bit bars though.
> >> 
> >> I'll update in the next round.  I think this has worked for me because I
> >> have only done single device testing.  I did switch from ffz when I
> >> rebased but I think ffz would still have this problem.
> >
> > For when are you planning the next round?
> 
> I'll send one out soon.  Perhaps tomorrow if all goes well.

I know, it's getting boring, but... which tomorrow?

Please just add the license headers and get the RFC committed. We'll get
the rest fixed up on top. We've been waiting for over a year now. This is
blocking any progress on the qtest coverage and probably already hurting
the quality of our releases.

Kevin