From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46243)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UPXSS-0005mZ-GT
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:15:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UPXSP-0000UI-RU
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:15:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36587)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UPXSP-0000U1-KO
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:15:25 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r39CFOLu027815
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 9 Apr 2013 08:15:24 -0400
Date: Tue, 9 Apr 2013 14:16:30 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130409111630.GB27374@redhat.com>
References: <1365503248-21275-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1365503248-21275-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: move vhost-net to
	config-host.mak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Apr 09, 2013 at 12:27:28PM +0200, Paolo Bonzini wrote:
> There is no reason why vhost-net should not work with TCG.
> Hence, put the limitation in hw/vhost-net.c, not straight in
> the config-*.mak files.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

If you want to enable vhost for tcg why not enable it, and fix
any fallout?

> ---
>  configure          | 6 +++---
>  hw/net/vhost_net.c | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configure b/configure
> index d5f2918..4b4b19e 100755
> --- a/configure
> +++ b/configure
> @@ -3686,6 +3686,9 @@ fi
>  if test "$virtfs" = "yes" ; then
>    echo "CONFIG_VIRTFS=y" >> $config_host_mak
>  fi
> +if test "$vhost_net" = "yes" ; then
> +  echo "CONFIG_VHOST_NET=y" >> $config_host_mak
> +fi
>  if test "$blobs" = "yes" ; then
>    echo "INSTALL_BLOBS=yes" >> $config_host_mak
>  fi
> @@ -4152,9 +4155,6 @@ case "$target_arch2" in
>        \( "$target_arch2" = "x86_64" -a "$cpu" = "i386"   \) -o \
>        \( "$target_arch2" = "i386"   -a "$cpu" = "x86_64" \) \) ; then
>        echo "CONFIG_KVM=y" >> $config_target_mak
> -      if test "$vhost_net" = "yes" ; then
> -        echo "CONFIG_VHOST_NET=y" >> $config_target_mak
> -      fi
>      fi
>  esac
>  case "$target_arch2" in
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 8c5384c..0956843 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -22,7 +22,7 @@
>  
>  #include "config.h"
>  
> -#ifdef CONFIG_VHOST_NET
> +#if defined CONFIG_LINUX && defined CONFIG_VHOST_NET && defined CONFIG_KVM
>  #include <linux/vhost.h>
>  #include <sys/socket.h>
>  #include <linux/kvm.h>
> -- 
> 1.8.1.4