From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UPb2Q-0002y1-A4
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 12:04:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UPb2O-0003TK-3D
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 12:04:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9705)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UPb2N-0003T2-KD
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 12:04:47 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r39G4lKv012034
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 9 Apr 2013 12:04:47 -0400
Date: Tue, 9 Apr 2013 11:52:06 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130409115206.64183ff8@redhat.com>
In-Reply-To: <51642E3C.5080600@redhat.com>
References: <3cbbe046d7a236711b868bb1565bf154d2389cb5.1365517320.git.minovotn@redhat.com>
	<51642E3C.5080600@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Revert "New QMP command query-cpu-max and
 HMP command cpu_max"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Michal Novotny <minovotn@redhat.com>, qemu-devel@nongnu.org

On Tue, 09 Apr 2013 09:05:32 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 04/09/2013 08:23 AM, Michal Novotny wrote:
> > This reverts commit 4d700430a20b3d53b7b15bc5f6666f7e570e3f2c as asked by
> > Luiz. The patch has been obsoleted by extending MachineInfo structure
> > by cpu-max field.
> > 
> > Signed-off-by: Michal Novotny <minovotn@redhat.com>
> > ---
> >  hmp-commands.hx  |  2 --
> >  hmp.c            |  8 --------
> >  hmp.h            |  1 -
> >  monitor.c        |  7 -------
> >  qapi-schema.json | 11 -----------
> >  qmp-commands.hx  | 22 ----------------------
> >  vl.c             |  5 -----
> >  7 files changed, 56 deletions(-)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> Safe if taken in time for 1.5 alongside the MachineInfo improvements.
> Libvirt has not yet coded up support to use either method, and is just
> fine using the method that gets cemented by the 1.5 release.

I've both patches in the QMP queue and will send a pull request this
week.

> 
> >  ##
> > -## @query-cpu-max
> > -##
> > -## query maximum number of CPUs supported by machine
> > -##
> > -## Returns: number of CPUs
> > -##
> > -## Since: 1.5
> > -###
> > -{ 'command': 'query-cpu-max', 'returns': 'int' }
>