From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPYq4-0004Yq-4p for qemu-devel@nongnu.org; Tue, 09 Apr 2013 09:43:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPYq0-0006YK-7y for qemu-devel@nongnu.org; Tue, 09 Apr 2013 09:43:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPYq0-0006YA-0M for qemu-devel@nongnu.org; Tue, 09 Apr 2013 09:43:52 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r39Dhp3X002850 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Apr 2013 09:43:51 -0400 Date: Tue, 9 Apr 2013 15:43:49 +0200 From: Kevin Wolf Message-ID: <20130409134349.GC2922@dhcp-200-207.str.redhat.com> References: <87y5cretjn.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y5cretjn.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v4 01/11] block: add error parameter to bdrv_snapshot_create() and related functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Pavel Hrdina , qemu-devel@nongnu.org, lcapitulino@redhat.com Am 09.04.2013 um 15:13 hat Markus Armbruster geschrieben: > When doing an error conversion, you have to decide "where to cut". > Everything above the cut is converted to Error. Everything below keeps > using other methods, such as returning -errno. > > Using Error sucks, because it's cumbersome. > > Using Error is nice, because you can report errors in more detail. > > Converting to Error is worthwhile when the niceness is worth the > suckage. > > This patch cuts below the block driver API. I'm not saying that's bad. > I just want to hear Kevin's opinion on it (cc'ed). I think for bdrv_snapshot_create() it could make sense to pass an Error object to the block drivers. Same thing for bdrv_create() or bdrv_open(). Most other functions probably can't make much use of it. Kevin