From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UPY1V-0005yb-G1
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:51:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UPY1U-0004Xh-5S
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:51:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59334)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UPY1T-0004XR-To
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:51:40 -0400
Date: Tue, 9 Apr 2013 14:51:26 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20130409145126.680fc36e@nial.usersys.redhat.com>
In-Reply-To: <5163FCA4.1020409@redhat.com>
References: <1365172636-28628-1-git-send-email-imammedo@redhat.com>
	<1365172636-28628-20-git-send-email-imammedo@redhat.com>
	<5163FCA4.1020409@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 18/22] target-i386: move IOAPIC to ICC bus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, afaerber@suse.de, lig.fnst@cn.fujitsu.com, rth@twiddle.net

On Tue, 09 Apr 2013 13:33:56 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 05/04/2013 16:37, Igor Mammedov ha scritto:
> > +    const char *ioapic_name = "ioapic";
> >  
> >      if (kvm_irqchip_in_kernel()) {
> > -        dev = qdev_create(NULL, "kvm-ioapic");
> > -    } else {
> > -        dev = qdev_create(NULL, "ioapic");
> > -    }
> > -    if (parent_name) {
> > -        object_property_add_child(object_resolve_path(parent_name, NULL),
> > -                                  "ioapic", OBJECT(dev), NULL);
> > +        ioapic_name = "kvm-ioapic";
> >      }
> > -    qdev_init_nofail(dev);
> > -    d = SYS_BUS_DEVICE(dev);
> > -    sysbus_mmio_map(d, 0, IO_APIC_DEFAULT_ADDRESS);
> > +    object_property_set_str(OBJECT(dev), ioapic_name, "ioapic-type",
> > NULL);
> 
> Why do you need this?
> 
> Having the IOAPIC as a QOM child of the icc-bridge is not too important,
> I think.  Perhaps not even too correct...
icc-bridge provides address space for IOAPIC, so it looked like a right thing
to make sure that destruction order would be IOAPIC first and only then parent
icc-bridge.

This patch is not really necessary for hot-plug, we could easily drop it, if
you prefer.

BTW:
 looks like this pre-reordering patch slipped in
 Correct one is "[PATCH 19/22] target-i386: move IOAPIC to ICC bus"

> 
> Paolo
>