From: "陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
To: li guang <lig.fnst@cn.fujitsu.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
proljc@gmail.com, e.voevodin@samsung.com, qemu-devel@nongnu.org,
blauwirbel@gmail.com, paul@codesourcery.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
"\"陳韋任" <chenwj@iis.sinica.edu.tw>,
afaerber@suse.de, aurelien@aurel32.net, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal
Date: Wed, 10 Apr 2013 10:31:11 +0800 [thread overview]
Message-ID: <20130410023111.GA11058@cs.nctu.edu.tw> (raw)
In-Reply-To: <1365553717.9553.88.camel@liguang.fnst.cn.fujitsu.com>
Hi liguang,
> OK, thanks!
> but, please make no mistake,
> I'm not saying this patch promote performance of TCG,
> this just optimize code writing of this function, of
> course code writing is not deemed to promote its performance.
> or, we shouldn't do any code change if they benefit little
> in performance?
IMO, if you are saying the patch can improve performance, then
you should run benchmark to convince others. If your patch is trying
to make code clear, then "optimize" might not be a good term to describe
your patch.
Regards,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj
next prev parent reply other threads:[~2013-04-10 2:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 3:45 [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal liguang
2013-04-09 8:05 ` 陳韋任 (Wei-Ren Chen)
2013-04-09 8:11 ` Paolo Bonzini
2013-04-09 8:21 ` li guang
2013-04-09 9:08 ` Peter Maydell
2013-04-10 0:28 ` li guang
2013-04-10 2:31 ` 陳韋任 (Wei-Ren Chen) [this message]
2013-04-10 2:38 ` li guang
2013-04-10 2:58 ` 陳韋任 (Wei-Ren Chen)
2013-04-10 3:03 ` li guang
2013-04-09 9:20 ` 陳韋任 (Wei-Ren Chen)
2013-04-11 2:12 ` li guang
2013-04-09 8:33 ` 陳韋任 (Wei-Ren Chen)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410023111.GA11058@cs.nctu.edu.tw \
--to=chenwj@iis.sinica.edu.tw \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=e.voevodin@samsung.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).