From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPkp9-000536-Rl for qemu-devel@nongnu.org; Tue, 09 Apr 2013 22:31:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPkp7-0001PJ-Bg for qemu-devel@nongnu.org; Tue, 09 Apr 2013 22:31:47 -0400 Received: from csmailer.cs.nctu.edu.tw ([140.113.235.130]:62326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPkp6-0001OI-QX for qemu-devel@nongnu.org; Tue, 09 Apr 2013 22:31:45 -0400 Date: Wed, 10 Apr 2013 10:31:11 +0800 From: =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= Message-ID: <20130410023111.GA11058@cs.nctu.edu.tw> References: <1365479139-18737-1-git-send-email-lig.fnst@cn.fujitsu.com> <20130409080529.GA86334@cs.nctu.edu.tw> <5163CD39.9000007@redhat.com> <1365495670.9553.59.camel@liguang.fnst.cn.fujitsu.com> <1365553717.9553.88.camel@liguang.fnst.cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1365553717.9553.88.camel@liguang.fnst.cn.fujitsu.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: li guang Cc: Peter Maydell , proljc@gmail.com, e.voevodin@samsung.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, paul@codesourcery.com, Paolo Bonzini , =?utf-8?B?IumZs+mfi+S7uw==?= , afaerber@suse.de, aurelien@aurel32.net, rth@twiddle.net Hi liguang, > OK, thanks! > but, please make no mistake, > I'm not saying this patch promote performance of TCG, > this just optimize code writing of this function, of > course code writing is not deemed to promote its performance. > or, we shouldn't do any code change if they benefit little > in performance? IMO, if you are saying the patch can improve performance, then you should run benchmark to convince others. If your patch is trying to make code clear, then "optimize" might not be a good term to describe your patch. Regards, chenwj =20 --=20 Wei-Ren Chen (=E9=99=B3=E9=9F=8B=E4=BB=BB) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj