From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53526)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UPqU8-0001BE-9l
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:34:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UPqU7-0006ta-5j
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:34:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44772)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UPqU6-0006tQ-U8
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 04:34:27 -0400
Date: Wed, 10 Apr 2013 10:34:15 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20130410103415.60c53beb@nial.usersys.redhat.com>
In-Reply-To: <1365580949-32467-1-git-send-email-lig.fnst@cn.fujitsu.com>
References: <1365580949-32467-1-git-send-email-lig.fnst@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] target-i386: remove cpu reset callback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: afaerber@suse.de, qemu-devel@nongnu.org

On Wed, 10 Apr 2013 16:02:28 +0800
liguang <lig.fnst@cn.fujitsu.com> wrote:

> we should remove it now, if not, cpu reset
> will do 2 times.
Currently CPU is bus-less device so there isn't anything to reset it during
reboot except callback. 
This patch will break reboot path, just try guest reboot from inside guest.


> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>  target-i386/cpu.c |    9 ---------
>  1 files changed, 0 insertions(+), 9 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 356378c..6e13053 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -2024,13 +2024,6 @@ bool cpu_is_bsp(X86CPU *cpu)
>  {
>      return cpu_get_apic_base(cpu->env.apic_state) & MSR_IA32_APICBASE_BSP;
>  }
> -
> -/* TODO: remove me, when reset over QOM tree is implemented */
> -static void x86_cpu_machine_reset_cb(void *opaque)
> -{
> -    X86CPU *cpu = opaque;
> -    cpu_reset(CPU(cpu));
> -}
>  #endif
>  
>  static void mce_init(X86CPU *cpu)
> @@ -2140,8 +2133,6 @@ static void x86_cpu_realizefn(DeviceState *dev, Error
> **errp) }
>  
>  #ifndef CONFIG_USER_ONLY
> -    qemu_register_reset(x86_cpu_machine_reset_cb, cpu);
> -
>      if (cpu->env.cpuid_features & CPUID_APIC || smp_cpus > 1) {
>          x86_cpu_apic_init(cpu, &local_err);
>          if (local_err != NULL) {