From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49006)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UPtHx-0008Vv-V9
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 07:34:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UPtHu-00008t-S5
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 07:34:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62939)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UPtHu-00007Q-K5
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 07:34:02 -0400
Date: Wed, 10 Apr 2013 13:35:07 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130410103507.GB16517@redhat.com>
References: <1365476681-31593-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1365476681-31593-9-git-send-email-mrhines@linux.vnet.ibm.com>
	<5164494F.1080705@redhat.com> <5164BC3C.6090400@linux.vnet.ibm.com>
	<51651DD3.50501@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51651DD3.50501@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v5: 08/12] new
 capabilities added and check for QMP string 'rdma'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, "Michael R. Hines" <mrhines@linux.vnet.ibm.com>, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com

On Wed, Apr 10, 2013 at 10:07:47AM +0200, Paolo Bonzini wrote:
> Il 10/04/2013 03:11, Michael R. Hines ha scritto:
> > Actually, this capability needs to be a part of the same patch.
> > 
> > RDMA must have the ability to turn this off or performance will die.
> 
> Yes, but you can put it in a separate patch at the beginning of this
> series.  RDMA depends on it, but it doesn't depend on RDMA.
> 
> Paolo

Further, it's an implementation detail really. We don't want
management to play with this capability - it will not know what
to set it to.  Let's just do the right thing automatically.

> > Similarly dynamic chunk registration on the server depends on having
> > the ability to turn this on, or you cannot get the advantages of dynamic
> > registration.