From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49514)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UPxeQ-0003fh-Oy
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 12:13:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UPxeP-0006wV-Bs
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 12:13:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2932)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UPxeP-0006wD-4D
	for qemu-devel@nongnu.org; Wed, 10 Apr 2013 12:13:33 -0400
Date: Wed, 10 Apr 2013 18:12:15 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20130410181215.4295873f@nial.usersys.redhat.com>
In-Reply-To: <1365553277.9553.82.camel@liguang.fnst.cn.fujitsu.com>
References: <1365172636-28628-1-git-send-email-imammedo@redhat.com>
	<1365172636-28628-9-git-send-email-imammedo@redhat.com>
	<1365387208.5674.38.camel@liguang.fnst.cn.fujitsu.com>
	<20130408133256.4f4a3fc8@nial.usersys.redhat.com>
	<5163FD4E.8050206@redhat.com>
	<1365553277.9553.82.camel@liguang.fnst.cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace
 FROM_SYSBUS() with QOM type cast
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: li guang <lig.fnst@cn.fujitsu.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, Paolo Bonzini <pbonzini@redhat.com>, afaerber@suse.de, rth@twiddle.net

On Wed, 10 Apr 2013 08:21:17 +0800
li guang <lig.fnst@cn.fujitsu.com> wrote:

> =E5=9C=A8 2013-04-09=E4=BA=8C=E7=9A=84 13:36 +0200=EF=BC=8CPaolo Bonzini=
=E5=86=99=E9=81=93=EF=BC=9A
> > Il 08/04/2013 13:32, Igor Mammedov ha scritto:
> > >=20
> > >> > This patch should be combined with [PATCH 07/22]
> > >> >=20
> > >> > =E5=9C=A8 2013-04-05=E4=BA=94=E7=9A=84 16:37 +0200=EF=BC=8CIgor Ma=
mmedov=E5=86=99=E9=81=93=EF=BC=9A
> > >>> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > >>> > > ---
> > >>> > >  hw/ioapic_common.c | 2 +-
> > >>> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>> > >=20
> > >>> > > diff --git a/hw/ioapic_common.c b/hw/ioapic_common.c
> > >>> > > index d4aff29..561b987 100644
> > >>> > > --- a/hw/ioapic_common.c
> > >>> > > +++ b/hw/ioapic_common.c
> > >>> > > @@ -59,7 +59,7 @@ static int ioapic_dispatch_post_load(void
> > >>> > > *opaque, int version_id)=20
> > >>> > >  static int ioapic_init_common(SysBusDevice *dev)
> > >>> > >  {
> > >>> > > -    IOAPICCommonState *s =3D FROM_SYSBUS(IOAPICCommonState, de=
v);
> > >>> > > +    IOAPICCommonState *s =3D IOAPIC_COMMON(dev);
> > >>> > >      IOAPICCommonClass *info;
> > >>> > >      static int ioapic_no;
> > >>> > > =20
> > >> >=20
> > >> >=20
> > >> >=20
> > > sure, will do this on the next respin.
> >=20
> > Actually no, why?  It's two different files.
>=20
> because they do the same trivial thing,
> do you want some mechanic changes separated?

There is no point arguing,
Andreas applied the first patch to qom-cpu tree already,
and seems he is fine taking them as separate patches.