From: Luiz Capitulino <lcapitulino@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qapi: use valid JSON in schema
Date: Thu, 11 Apr 2013 08:50:50 -0400 [thread overview]
Message-ID: <20130411085050.3c3847bf@redhat.com> (raw)
In-Reply-To: <1365621164-17079-1-git-send-email-eblake@redhat.com>
On Wed, 10 Apr 2013 13:12:44 -0600
Eric Blake <eblake@redhat.com> wrote:
> * qapi-schema.json: JSON doesn't allow trailing commas.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Applied to the qmp branch, thanks.
> ---
>
> a multi-line regex search for ',[ \n]*[]}]' didn't turn up any
> other violations
>
> qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index db542f6..044517d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1600,7 +1600,7 @@
> ##
> { 'union': 'BlockdevAction',
> 'data': {
> - 'blockdev-snapshot-sync': 'BlockdevSnapshot',
> + 'blockdev-snapshot-sync': 'BlockdevSnapshot'
> } }
>
> ##
prev parent reply other threads:[~2013-04-11 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 19:12 [Qemu-devel] [PATCH] qapi: use valid JSON in schema Eric Blake
2013-04-11 12:50 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411085050.3c3847bf@redhat.com \
--to=lcapitulino@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).