From: Luiz Capitulino <lcapitulino@redhat.com>
To: fred.konrad@greensocs.com
Cc: cornelia.huck@de.ibm.com, peter.maydell@linaro.org,
aliguori@us.ibm.com, mark.burton@greensocs.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio: fix broken aliases.
Date: Thu, 11 Apr 2013 09:48:15 -0400 [thread overview]
Message-ID: <20130411094815.1c6f5eb8@redhat.com> (raw)
In-Reply-To: <1365501888-14602-1-git-send-email-fred.konrad@greensocs.com>
On Tue, 9 Apr 2013 12:04:48 +0200
fred.konrad@greensocs.com wrote:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
>
> This fix the broken aliases, by renaming the devices.
>
> So: * virtio-blk => virtio-blk-device.
> * virtio-balloon => virtio-balloon-device.
> * virtio-scsi => virtio-scsi-device.
>
> All virtio-*-pci, virtio-*-s390, virtio-*-ccw didn't change.
>
> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
Please apply, as this breaks command-line compatibility.
> ---
> include/hw/virtio/virtio-balloon.h | 2 +-
> include/hw/virtio/virtio-blk.h | 2 +-
> include/hw/virtio/virtio-scsi.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/virtio-balloon.h
> index 3b459bb..f863bfe 100644
> --- a/include/hw/virtio/virtio-balloon.h
> +++ b/include/hw/virtio/virtio-balloon.h
> @@ -18,7 +18,7 @@
> #include "hw/virtio/virtio.h"
> #include "hw/pci/pci.h"
>
> -#define TYPE_VIRTIO_BALLOON "virtio-balloon"
> +#define TYPE_VIRTIO_BALLOON "virtio-balloon-device"
> #define VIRTIO_BALLOON(obj) \
> OBJECT_CHECK(VirtIOBalloon, (obj), TYPE_VIRTIO_BALLOON)
>
> diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
> index c10d069..fc71853 100644
> --- a/include/hw/virtio/virtio-blk.h
> +++ b/include/hw/virtio/virtio-blk.h
> @@ -17,7 +17,7 @@
> #include "hw/virtio/virtio.h"
> #include "hw/block/block.h"
>
> -#define TYPE_VIRTIO_BLK "virtio-blk"
> +#define TYPE_VIRTIO_BLK "virtio-blk-device"
> #define VIRTIO_BLK(obj) \
> OBJECT_CHECK(VirtIOBlock, (obj), TYPE_VIRTIO_BLK)
>
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index c9d92ca..ccd7b06 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -18,7 +18,7 @@
> #include "hw/pci/pci.h"
> #include "hw/scsi/scsi.h"
>
> -#define TYPE_VIRTIO_SCSI "virtio-scsi"
> +#define TYPE_VIRTIO_SCSI "virtio-scsi-device"
> #define VIRTIO_SCSI(obj) \
> OBJECT_CHECK(VirtIOSCSI, (obj), TYPE_VIRTIO_SCSI)
>
next prev parent reply other threads:[~2013-04-11 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 10:04 [Qemu-devel] [PATCH] virtio: fix broken aliases fred.konrad
2013-04-11 13:48 ` Luiz Capitulino [this message]
2013-04-15 21:10 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411094815.1c6f5eb8@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=fred.konrad@greensocs.com \
--cc=mark.burton@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).