From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47594)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UQHrW-0001Wc-0n
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 09:48:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UQHrU-0001y7-IQ
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 09:48:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53093)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UQHrU-0001xw-AU
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 09:48:24 -0400
Date: Thu, 11 Apr 2013 09:48:15 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130411094815.1c6f5eb8@redhat.com>
In-Reply-To: <1365501888-14602-1-git-send-email-fred.konrad@greensocs.com>
References: <1365501888-14602-1-git-send-email-fred.konrad@greensocs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio: fix broken aliases.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com
Cc: cornelia.huck@de.ibm.com, peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org

On Tue,  9 Apr 2013 12:04:48 +0200
fred.konrad@greensocs.com wrote:

> From: KONRAD Frederic <fred.konrad@greensocs.com>
> 
> This fix the broken aliases, by renaming the devices.
> 
> So: * virtio-blk => virtio-blk-device.
>     * virtio-balloon => virtio-balloon-device.
>     * virtio-scsi => virtio-scsi-device.
> 
> All virtio-*-pci, virtio-*-s390, virtio-*-ccw didn't change.
> 
> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>

Tested-by: Luiz Capitulino <lcapitulino@redhat.com>

Please apply, as this breaks command-line compatibility.

> ---
>  include/hw/virtio/virtio-balloon.h | 2 +-
>  include/hw/virtio/virtio-blk.h     | 2 +-
>  include/hw/virtio/virtio-scsi.h    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/virtio-balloon.h
> index 3b459bb..f863bfe 100644
> --- a/include/hw/virtio/virtio-balloon.h
> +++ b/include/hw/virtio/virtio-balloon.h
> @@ -18,7 +18,7 @@
>  #include "hw/virtio/virtio.h"
>  #include "hw/pci/pci.h"
>  
> -#define TYPE_VIRTIO_BALLOON "virtio-balloon"
> +#define TYPE_VIRTIO_BALLOON "virtio-balloon-device"
>  #define VIRTIO_BALLOON(obj) \
>          OBJECT_CHECK(VirtIOBalloon, (obj), TYPE_VIRTIO_BALLOON)
>  
> diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
> index c10d069..fc71853 100644
> --- a/include/hw/virtio/virtio-blk.h
> +++ b/include/hw/virtio/virtio-blk.h
> @@ -17,7 +17,7 @@
>  #include "hw/virtio/virtio.h"
>  #include "hw/block/block.h"
>  
> -#define TYPE_VIRTIO_BLK "virtio-blk"
> +#define TYPE_VIRTIO_BLK "virtio-blk-device"
>  #define VIRTIO_BLK(obj) \
>          OBJECT_CHECK(VirtIOBlock, (obj), TYPE_VIRTIO_BLK)
>  
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index c9d92ca..ccd7b06 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -18,7 +18,7 @@
>  #include "hw/pci/pci.h"
>  #include "hw/scsi/scsi.h"
>  
> -#define TYPE_VIRTIO_SCSI "virtio-scsi"
> +#define TYPE_VIRTIO_SCSI "virtio-scsi-device"
>  #define VIRTIO_SCSI(obj) \
>          OBJECT_CHECK(VirtIOSCSI, (obj), TYPE_VIRTIO_SCSI)
>