Re: [Qemu-devel] RFC: vfio API changes needed for powerpc (v3)

[Joerg Roedel <joro@8bytes.org>]

On Tue, Apr 09, 2013 at 01:22:15AM +0000, Yoder Stuart-B08248 wrote:
> > What happens if a normal unmap call is done on the MSI iova?  Do we
> > need a separate unmap?
> 
> I was thinking a normal unmap on an MSI windows would be an error...but
> I'm not set on that.   I put the msi unmap there to make things symmetric,
> a normal unmap would work as well...and then we could drop the msi unmap.

Hmm, this API semantic isn't very clean. When you explicitly map the MSI
banks a clean API would also allow to unmap them. But that is not
possible in your design because the kernel is responsible for mapping
MSIs and you can't unmap a MSI bank that is in use by the kernel.

So since the kernel owns the MSI setup anyways it should also take care
of mapping the MSI banks. What is the reason to not let the kernel
allocate the MSI banks top-down from the end of the DMA window space?
Just let userspace know (or even set if needed) in advance how many of
the windows it configures the kernel will take for mapping MSI banks and
you are fine, no?


	Joerg