From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39966)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UQa0b-0000wK-52
	for qemu-devel@nongnu.org; Fri, 12 Apr 2013 05:11:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UQa0Z-000853-RF
	for qemu-devel@nongnu.org; Fri, 12 Apr 2013 05:11:01 -0400
Received: from mail-wg0-f50.google.com ([74.125.82.50]:63141)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UQa0Z-00083E-GU
	for qemu-devel@nongnu.org; Fri, 12 Apr 2013 05:10:59 -0400
Received: by mail-wg0-f50.google.com with SMTP id k13so2415245wgh.17
	for <qemu-devel@nongnu.org>; Fri, 12 Apr 2013 02:10:58 -0700 (PDT)
Date: Fri, 12 Apr 2013 11:10:55 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130412091055.GG31055@stefanha-thinkpad.redhat.com>
References: <1365730875-22854-1-git-send-email-aik@ozlabs.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1365730875-22854-1-git-send-email-aik@ozlabs.ru>
Subject: Re: [Qemu-devel] [PATCH] bswap: fix compiler warning
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, David Gibson <david@gibson.dropbear.id.au>

On Fri, Apr 12, 2013 at 11:41:15AM +1000, Alexey Kardashevskiy wrote:
> The bswap functions use memcpy but the bswap.h header itself does not seem to
> include it in some configuration such as cross compiling for powerpc64
> on x86_64 machine (gcc 4.6.3 from ftp.kernel.org, headers/libs from FC18/ppc64),
> the example warning is below.
> 
> The patch explicitly includes string.h.
> 
>   CC    ppc64-softmmu/hw/virtio/virtio.o
> In file included from /home/alexey/qemu/include/libfdt_env.h:22:0,
>                  from /home/alexey/qemu/../lib4qemu/usr/include/libfdt.h:54,
>                  from /home/alexey/qemu/hw/nvram/spapr_nvram.c:25:
> /home/alexey/qemu/include/qemu/bswap.h: In function 'lduw_p':
> /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: implicit declaration of function 'memcpy' [-Wimplicit-function-declaration]
> /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: incompatible implicit declaration of built-in function 'memcpy' [enabled by default]
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  include/qemu/bswap.h |    2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>