From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQcE1-0005Dr-J5 for qemu-devel@nongnu.org; Fri, 12 Apr 2013 07:33:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQcDw-0001Z1-SX for qemu-devel@nongnu.org; Fri, 12 Apr 2013 07:33:01 -0400 Date: Fri, 12 Apr 2013 13:32:52 +0200 From: Stefan Hajnoczi Message-ID: <20130412113252.GC9747@stefanha-thinkpad.redhat.com> References: <1365436306-20152-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1365436306-20152-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-moxie: Fix VMState registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, Anthony Green , qemu-devel@nongnu.org, patches@linaro.org On Mon, Apr 08, 2013 at 04:51:46PM +0100, Peter Maydell wrote: > Register the CPU VMState in the correct way, via cpu_class_set_vmsd(), > rather than doing it in two different wrong ways (once by providing > cpu_save and cpu_load functions, and once by setting the vmsd field in > DeviceClass). > > Signed-off-by: Peter Maydell > --- > Having just revamped the target-arm vmstate code I now have a > better grasp of how it should work, so I noticed we didn't quite > get moxie right. Not really very tested since I couldn't find a test > image to try, but should work better than the previous code... > > target-moxie/cpu.c | 2 +- > target-moxie/cpu.h | 2 -- > target-moxie/machine.c | 12 +----------- > 3 files changed, 2 insertions(+), 14 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan