From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQbja-0002VE-3s for qemu-devel@nongnu.org; Fri, 12 Apr 2013 07:01:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQbjW-0005wM-3E for qemu-devel@nongnu.org; Fri, 12 Apr 2013 07:01:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQbjV-0005w2-Rv for qemu-devel@nongnu.org; Fri, 12 Apr 2013 07:01:30 -0400 Date: Fri, 12 Apr 2013 13:00:57 +0200 From: Igor Mammedov Message-ID: <20130412130057.42d742e5@thinkpad> In-Reply-To: <20130411184647.GI6862@otherpad.lan.raisama.net> References: <1365691918-30594-1-git-send-email-imammedo@redhat.com> <1365691918-30594-7-git-send-email-imammedo@redhat.com> <20130411184647.GI6862@otherpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/19] introduce CPU hot-plug notifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: aliguori@us.ibm.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, pbonzini@redhat.com, afaerber@suse.de, lig.fnst@cn.fujitsu.com, rth@twiddle.net On Thu, 11 Apr 2013 15:46:47 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:45PM +0200, Igor Mammedov wrote: > > hot-added CPU will be distributed to acpi_piix4, rtc_cmos and icc_bridge > > > > Signed-off-by: Igor Mammedov > > Reviewed-by: Paolo Bonzini > > Have you considered making a generic device creation/realization > notification mechanism, that could work with any device class? Not really, that would make notification handler a bit more complicated, since they will have to decide if event belong to them. We could add it in future if there will be need for it. > > > --- > > v2: > > * move notifier to qom/cpu.c and call it from CPUClass.realize() on hotplug > > * remove get_firmware_id() since it belong to other patch > > --- > > include/sysemu/sysemu.h | 3 +++ > > qom/cpu.c | 12 ++++++++++++ > > 2 files changed, 15 insertions(+) > > > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > > index 6578782..a8c3de1 100644 > > --- a/include/sysemu/sysemu.h > > +++ b/include/sysemu/sysemu.h > > @@ -152,6 +152,9 @@ void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict); > > /* generic hotplug */ > > void drive_hot_add(Monitor *mon, const QDict *qdict); > > > > +/* CPU hotplug */ > > +void qemu_register_cpu_added_notifier(Notifier *notifier); > > + > > /* pcie aer error injection */ > > void pcie_aer_inject_error_print(Monitor *mon, const QObject *data); > > int do_pcie_aer_inject_error(Monitor *mon, > > diff --git a/qom/cpu.c b/qom/cpu.c > > index 2869cfe..fe85960 100644 > > --- a/qom/cpu.c > > +++ b/qom/cpu.c > > @@ -22,6 +22,17 @@ > > #include "qemu-common.h" > > #include "sysemu/kvm.h" > > #include "sysemu/cpus.h" > > +#include "qemu/notify.h" > > +#include "sysemu/sysemu.h" > > + > > +/* CPU hot-plug notifiers */ > > +static NotifierList cpu_added_notifiers = > > + NOTIFIER_LIST_INITIALIZER(cpu_add_notifiers); > > + > > +void qemu_register_cpu_added_notifier(Notifier *notifier) > > +{ > > + notifier_list_add(&cpu_added_notifiers, notifier); > > +} > > > > void cpu_reset_interrupt(CPUState *cpu, int mask) > > { > > @@ -62,6 +73,7 @@ static void cpu_common_realizefn(DeviceState *dev, Error **errp) > > if (dev->hotplugged) { > > cpu_synchronize_post_init(CPU(dev)); > > resume_vcpu(CPU(dev)); > > + notifier_list_notify(&cpu_added_notifiers, dev); > > } > > } > > > > -- > > 1.8.2 > > > > -- > Eduardo -- Regards, Igor