From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36638)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1UReMY-0003ZO-EU
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:02:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1UReMW-0007hB-AZ
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:02:06 -0400
Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:48905)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1UReMV-0007gg-UE
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:02:04 -0400
Date: Mon, 15 Apr 2013 10:01:57 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130415080156.GA11555@ohm.aurel32.net>
References: <1365116186-19382-1-git-send-email-rth@twiddle.net>
	<1365116186-19382-26-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1365116186-19382-26-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v4 25/33] tcg-ppc64: Cleanup i32 constants
 to tcg_out_cmp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: av1474@comtv.ru, qemu-devel@nongnu.org

On Thu, Apr 04, 2013 at 05:56:18PM -0500, Richard Henderson wrote:
> Nothing else in the call chain ensures that these
> constants don't have garbage in the high bits.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/ppc64/tcg-target.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
> index edb2b6c..27d5ea5 100644
> --- a/tcg/ppc64/tcg-target.c
> +++ b/tcg/ppc64/tcg-target.c
> @@ -1059,6 +1059,11 @@ static void tcg_out_cmp (TCGContext *s, int cond, TCGArg arg1, TCGArg arg2,
>      int imm;
>      uint32_t op;
>  
> +    /* Simplify the comparisons below wrt CMPI.  */
> +    if (type == TCG_TYPE_I32) {
> +        arg2 = (int32_t)arg2;
> +    }
> +
>      switch (cond) {
>      case TCG_COND_EQ:
>      case TCG_COND_NE:

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net