From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48661)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1URelQ-000791-OR
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:27:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1URelP-0001gU-0D
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:27:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13520)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1URelO-0001g1-PL
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:27:46 -0400
Date: Mon, 15 Apr 2013 10:27:43 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20130415102743.3d3ed016@nial.usersys.redhat.com>
In-Reply-To: <1365710844-30453-2-git-send-email-ehabkost@redhat.com>
References: <1365710844-30453-1-git-send-email-ehabkost@redhat.com>
	<1365710844-30453-2-git-send-email-ehabkost@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH qom-cpu-next 1/2] target-i386/cpu.c: Coding
	style fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Thu, 11 Apr 2013 17:07:23 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

>  * Add braces to 'if' statements;
>  * Remove last TAB character from the source.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index f1ccc72..c2e02fe 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1870,12 +1870,13 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t
> index, uint32_t count, if (env->cpuid_ext2_features & CPUID_EXT2_LM) {
>              /* 64 bit processor */
>  /* XXX: The physical address space is limited to 42 bits in exec.c. */
> -            *eax = 0x00003028;	/* 48 bits virtual, 40 bits physical
> */
> +            *eax = 0x00003028;  /* 48 bits virtual, 40 bits physical */
                                 ^^ 2 spaces when in other places only one
                                    
>          } else {
> -            if (env->cpuid_features & CPUID_PSE36)
> +            if (env->cpuid_features & CPUID_PSE36) {
>                  *eax = 0x00000024; /* 36 bits physical */
> -            else
> +            } else {
>                  *eax = 0x00000020; /* 32 bits physical */
> +            }
>          }
>          *ebx = 0;
>          *ecx = 0;

with fix above Reviewed-By: Igor Mammedov <imammedo@redhat.com>