From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH RFC] vhost: fix vhost force with msix=off
Date: Mon, 15 Apr 2013 17:40:24 +0300 [thread overview]
Message-ID: <20130415144024.GA20178@redhat.com> (raw)
In response to a bug report on IRC: this should fix it I think?
Need to test properly but out of time for today,
compiled only. Hope this helps.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 8bba0f3..d0fcc6c 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -758,6 +758,10 @@ static int virtio_pci_set_guest_notifier(DeviceState *d, int n, bool assign,
event_notifier_cleanup(notifier);
}
+ if (!msix_enabled(&proxy->pci_dev) && proxy->vdev->guest_notifier_mask) {
+ proxy->vdev->guest_notifier_mask(proxy->vdev, n, !assign);
+ }
+
return 0;
}
next reply other threads:[~2013-04-15 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 14:40 Michael S. Tsirkin [this message]
2013-04-17 12:03 ` [Qemu-devel] [PATCH RFC] vhost: fix vhost force with msix=off Christian Borntraeger
2013-04-17 13:42 ` Michael S. Tsirkin
2013-04-18 7:55 ` Christian Borntraeger
2013-04-22 9:11 ` [Qemu-devel] [PATCH RFC 0/3] virtio-ccw: Add notifiers support Cornelia Huck
2013-04-22 9:11 ` [Qemu-devel] [PATCH RFC 1/3] linux-headers: Update with ioeventfd changes Cornelia Huck
2013-04-22 9:11 ` [Qemu-devel] [PATCH RFC 2/3] virtio-ccw: Wire up ioeventfd Cornelia Huck
2013-04-22 9:11 ` [Qemu-devel] [PATCH RFC 3/3] virtio-ccw: Wire up guest and host notifies Cornelia Huck
2013-04-18 17:19 ` [Qemu-devel] [PATCH RFC] vhost: fix vhost force with msix=off Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415144024.GA20178@redhat.com \
--to=mst@redhat.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).