From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URjD6-0001wS-IG for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:12:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URjD1-00071d-97 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:12:40 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:48549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URjD0-000717-Uv for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:12:35 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Apr 2013 14:09:50 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1E834219005A for ; Mon, 15 Apr 2013 14:14:44 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3FDCKaT49414356 for ; Mon, 15 Apr 2013 13:12:20 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3FDCT6s005994 for ; Mon, 15 Apr 2013 07:12:29 -0600 Date: Mon, 15 Apr 2013 15:12:26 +0200 From: Cornelia Huck Message-ID: <20130415151226.762e177f@gondolin> In-Reply-To: <1365944470-13837-1-git-send-email-fred.konrad@greensocs.com> References: <1365944470-13837-1-git-send-email-fred.konrad@greensocs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/8] virtio-rng refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: amit.shah@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org On Sun, 14 Apr 2013 15:01:02 +0200 fred.konrad@greensocs.com wrote: > From: KONRAD Frederic > > This is the last backend of the refactoring. > > Basically it creates virtio-rng-device which extends virtio-device. > Then a virtio-rng-device can be connected on a virtio-bus. > virtio-rng-pci, virtio-rng-s390, virtio-rng-ccw are created too, they extend > respectively virtio-pci, virtio-s390-device, virtio-ccw-device and have a > virtio-rng-device. > > When rng option is NULL, a default rng backend is created as before. But after > this refactoring, this default-backend will be the child of virtio-rng-device > instead of virtio-rng-*. > > You can checkout my branch here: > > git://project.greensocs.com/qemu-virtio.git virtio-rng-v3 > > Note that it is nearly the same series as virtio-blk and virtio-scsi > refactoring, and is rebased on top of virtio-net-v3 I posted before. > > I made basic tests (with linux guests) on: > * qemu-system-i386 On s390, with virtio-ccw and s390-virtio: Tested-by: Cornelia Huck > > Changes v2 -> v3: > * Added CCW device. > * Changes name: "virtio-rng" => "virtio-rng-device". > * Rebased. > > Thanks, > > Fred > > KONRAD Frederic (8): > virtio-rng: don't use pointer for configuration. > virtio-rng: add virtio-rng device. > virtio-rng-pci: switch to the new API. > virtio-rng-s390: switch to the new API. > virtio-rng-ccw: switch to the new API. > virtio-rng: cleanup: init and exit functions. > virtio-rng: cleanup: remove qdev field. > virtio-rng: cleanup: use QOM casts. > > hw/s390x/s390-virtio-bus.c | 38 +++++----- > hw/s390x/s390-virtio-bus.h | 12 +++- > hw/s390x/virtio-ccw.c | 49 ++++++------- > hw/s390x/virtio-ccw.h | 12 +++- > hw/virtio/virtio-pci.c | 156 ++++++++++++++++------------------------- > hw/virtio/virtio-pci.h | 14 +++- > hw/virtio/virtio-rng.c | 120 ++++++++++++++++++++++--------- > include/hw/virtio/virtio-rng.h | 20 ++++-- > include/hw/virtio/virtio.h | 2 - > 9 files changed, 240 insertions(+), 183 deletions(-) >