From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URjEh-0004L8-1J for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:15:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URjEG-0007cy-8b for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:14:18 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:52727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URjEF-0007by-TI for qemu-devel@nongnu.org; Mon, 15 Apr 2013 09:13:52 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Apr 2013 14:10:52 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9631617D801B for ; Mon, 15 Apr 2013 14:14:43 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3FDDdt644105846 for ; Mon, 15 Apr 2013 13:13:39 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3FDDmPS004189 for ; Mon, 15 Apr 2013 07:13:49 -0600 Date: Mon, 15 Apr 2013 15:13:46 +0200 From: Cornelia Huck Message-ID: <20130415151346.0597c19e@gondolin> In-Reply-To: <1365945289-14122-1-git-send-email-fred.konrad@greensocs.com> References: <1365945289-14122-1-git-send-email-fred.konrad@greensocs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-rng-s390: add properties. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, Alexander Graf On Sun, 14 Apr 2013 15:14:49 +0200 fred.konrad@greensocs.com wrote: > From: KONRAD Frederic > > I don't see any reason why these properties are missing. Acked-by: Cornelia Huck > > Cc: Cornelia Huck > Cc: Alexander Graf > Signed-off-by: KONRAD Frederic > > Note: Need to apply virtio-rng-refactoring first! Looks sane here. > --- > hw/s390x/s390-virtio-bus.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c > index 4d9f2ec..0d915af 100644 > --- a/hw/s390x/s390-virtio-bus.c > +++ b/hw/s390x/s390-virtio-bus.c > @@ -514,11 +514,19 @@ static const TypeInfo s390_virtio_serial = { > .class_init = s390_virtio_serial_class_init, > }; > > +static Property s390_virtio_rng_properties[] = { > + DEFINE_VIRTIO_COMMON_FEATURES(VirtIOS390Device, host_features), > + DEFINE_VIRTIO_RNG_PROPERTIES(VirtIORNGS390, vdev.conf), > + DEFINE_PROP_END_OF_LIST(), > +}; > + > static void s390_virtio_rng_class_init(ObjectClass *klass, void *data) > { > + DeviceClass *dc = DEVICE_CLASS(klass); > VirtIOS390DeviceClass *k = VIRTIO_S390_DEVICE_CLASS(klass); > > k->init = s390_virtio_rng_init; > + dc->props = s390_virtio_rng_properties; > } > > static const TypeInfo s390_virtio_rng = {