* [Qemu-devel] [PATCH] virtio-rng-s390: add properties.
@ 2013-04-14 13:14 fred.konrad
2013-04-15 13:13 ` Cornelia Huck
0 siblings, 1 reply; 4+ messages in thread
From: fred.konrad @ 2013-04-14 13:14 UTC (permalink / raw)
To: qemu-devel, aliguori
Cc: cornelia.huck, peter.maydell, mark.burton, Alexander Graf,
fred.konrad
From: KONRAD Frederic <fred.konrad@greensocs.com>
I don't see any reason why these properties are missing.
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
Note: Need to apply virtio-rng-refactoring first!
---
hw/s390x/s390-virtio-bus.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
index 4d9f2ec..0d915af 100644
--- a/hw/s390x/s390-virtio-bus.c
+++ b/hw/s390x/s390-virtio-bus.c
@@ -514,11 +514,19 @@ static const TypeInfo s390_virtio_serial = {
.class_init = s390_virtio_serial_class_init,
};
+static Property s390_virtio_rng_properties[] = {
+ DEFINE_VIRTIO_COMMON_FEATURES(VirtIOS390Device, host_features),
+ DEFINE_VIRTIO_RNG_PROPERTIES(VirtIORNGS390, vdev.conf),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
static void s390_virtio_rng_class_init(ObjectClass *klass, void *data)
{
+ DeviceClass *dc = DEVICE_CLASS(klass);
VirtIOS390DeviceClass *k = VIRTIO_S390_DEVICE_CLASS(klass);
k->init = s390_virtio_rng_init;
+ dc->props = s390_virtio_rng_properties;
}
static const TypeInfo s390_virtio_rng = {
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-rng-s390: add properties.
2013-04-14 13:14 [Qemu-devel] [PATCH] virtio-rng-s390: add properties fred.konrad
@ 2013-04-15 13:13 ` Cornelia Huck
2013-04-26 17:17 ` Alexander Graf
0 siblings, 1 reply; 4+ messages in thread
From: Cornelia Huck @ 2013-04-15 13:13 UTC (permalink / raw)
To: fred.konrad
Cc: peter.maydell, aliguori, mark.burton, qemu-devel, Alexander Graf
On Sun, 14 Apr 2013 15:14:49 +0200
fred.konrad@greensocs.com wrote:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
>
> I don't see any reason why these properties are missing.
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>
> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
>
> Note: Need to apply virtio-rng-refactoring first!
Looks sane here.
> ---
> hw/s390x/s390-virtio-bus.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
> index 4d9f2ec..0d915af 100644
> --- a/hw/s390x/s390-virtio-bus.c
> +++ b/hw/s390x/s390-virtio-bus.c
> @@ -514,11 +514,19 @@ static const TypeInfo s390_virtio_serial = {
> .class_init = s390_virtio_serial_class_init,
> };
>
> +static Property s390_virtio_rng_properties[] = {
> + DEFINE_VIRTIO_COMMON_FEATURES(VirtIOS390Device, host_features),
> + DEFINE_VIRTIO_RNG_PROPERTIES(VirtIORNGS390, vdev.conf),
> + DEFINE_PROP_END_OF_LIST(),
> +};
> +
> static void s390_virtio_rng_class_init(ObjectClass *klass, void *data)
> {
> + DeviceClass *dc = DEVICE_CLASS(klass);
> VirtIOS390DeviceClass *k = VIRTIO_S390_DEVICE_CLASS(klass);
>
> k->init = s390_virtio_rng_init;
> + dc->props = s390_virtio_rng_properties;
> }
>
> static const TypeInfo s390_virtio_rng = {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-rng-s390: add properties.
2013-04-15 13:13 ` Cornelia Huck
@ 2013-04-26 17:17 ` Alexander Graf
2013-04-26 17:18 ` Alexander Graf
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Graf @ 2013-04-26 17:17 UTC (permalink / raw)
To: Cornelia Huck
Cc: peter.maydell, aliguori, mark.burton, qemu-devel, fred.konrad
On 15.04.2013, at 15:13, Cornelia Huck wrote:
> On Sun, 14 Apr 2013 15:14:49 +0200
> fred.konrad@greensocs.com wrote:
>
>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>
>> I don't see any reason why these properties are missing.
>
> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Connie, could you please take these?
Thanks,
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-rng-s390: add properties.
2013-04-26 17:17 ` Alexander Graf
@ 2013-04-26 17:18 ` Alexander Graf
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Graf @ 2013-04-26 17:18 UTC (permalink / raw)
To: Cornelia Huck
Cc: peter.maydell, aliguori, mark.burton, qemu-devel, fred.konrad
On 26.04.2013, at 19:17, Alexander Graf wrote:
>
> On 15.04.2013, at 15:13, Cornelia Huck wrote:
>
>> On Sun, 14 Apr 2013 15:14:49 +0200
>> fred.konrad@greensocs.com wrote:
>>
>>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>>
>>> I don't see any reason why these properties are missing.
>>
>> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>
> Connie, could you please take these?
Scratch this.
Applied to s390-next. Thank you :)
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-26 17:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-14 13:14 [Qemu-devel] [PATCH] virtio-rng-s390: add properties fred.konrad
2013-04-15 13:13 ` Cornelia Huck
2013-04-26 17:17 ` Alexander Graf
2013-04-26 17:18 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).