From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URpuZ-0003of-Tv for qemu-devel@nongnu.org; Mon, 15 Apr 2013 16:22:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URpuY-0005Em-Rf for qemu-devel@nongnu.org; Mon, 15 Apr 2013 16:21:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URpuY-0005Eg-KB for qemu-devel@nongnu.org; Mon, 15 Apr 2013 16:21:58 -0400 Date: Mon, 15 Apr 2013 22:21:16 +0200 From: Igor Mammedov Message-ID: <20130415222116.07643d77@thinkpad> In-Reply-To: <20130415195710.GN6862@otherpad.lan.raisama.net> References: <1365691918-30594-1-git-send-email-imammedo@redhat.com> <1365691918-30594-5-git-send-email-imammedo@redhat.com> <20130415195710.GN6862@otherpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: aliguori@us.ibm.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, pbonzini@redhat.com, afaerber@suse.de, lig.fnst@cn.fujitsu.com, rth@twiddle.net On Mon, 15 Apr 2013 16:57:10 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:43PM +0200, Igor Mammedov wrote: > [...] > > diff --git a/kvm-all.c b/kvm-all.c > > index fc4e17c..1d17128 100644 > > --- a/kvm-all.c > > +++ b/kvm-all.c > > @@ -109,6 +109,7 @@ bool kvm_async_interrupts_allowed; > > bool kvm_irqfds_allowed; > > bool kvm_msi_via_irqfd_allowed; > > bool kvm_gsi_routing_allowed; > > +bool kvm_allowed; > > > > static const KVMCapabilityInfo kvm_required_capabilites[] = { > > KVM_CAP_INFO(USER_MEMORY), > > diff --git a/kvm-stub.c b/kvm-stub.c > > index b34064a..8cb81c4 100644 > > --- a/kvm-stub.c > > +++ b/kvm-stub.c > > @@ -23,6 +23,7 @@ bool kvm_async_interrupts_allowed; > > bool kvm_irqfds_allowed; > > bool kvm_msi_via_irqfd_allowed; > > bool kvm_gsi_routing_allowed; > > +bool kvm_allowed; > > Why do you need kvm_allowed on kvm-stub.c? Isn't simpler and more > efficient to define kvm_enabled() as (0) on CONFIG_USER_ONLY? qom/cpu.o is build only one time for all targets, header ifdef won't work here. > -- > Eduardo -- Regards, Igor