From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51867)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1US2Y7-00084t-0Z
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 05:51:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1US2Y5-0003mN-Om
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 05:51:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42169)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1US2Y5-0003lW-9V
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 05:51:37 -0400
Date: Tue, 16 Apr 2013 15:21:28 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20130416095128.GB6737@amit.redhat.com>
References: <1365944470-13837-1-git-send-email-fred.konrad@greensocs.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1365944470-13837-1-git-send-email-fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/8] virtio-rng refactoring.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com
Cc: cornelia.huck@de.ibm.com, peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org

On (Sun) 14 Apr 2013 [15:01:02], fred.konrad@greensocs.com wrote:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
> 
> This is the last backend of the refactoring.
> 
> Basically it creates virtio-rng-device which extends virtio-device.
> Then a virtio-rng-device can be connected on a virtio-bus.
> virtio-rng-pci, virtio-rng-s390, virtio-rng-ccw are created too, they extend
> respectively virtio-pci, virtio-s390-device, virtio-ccw-device and have a
> virtio-rng-device.
> 
> When rng option is NULL, a default rng backend is created as before. But after
> this refactoring, this default-backend will be the child of virtio-rng-device
> instead of virtio-rng-*.
> 
> You can checkout my branch here:
> 
> git://project.greensocs.com/qemu-virtio.git virtio-rng-v3
> 
> Note that it is nearly the same series as virtio-blk and virtio-scsi
> refactoring, and is rebased on top of virtio-net-v3 I posted before.
> 
> I made basic tests (with linux guests) on:
>  * qemu-system-i386

Looks OK.

Acked-by: Amit Shah <amit.shah@redhat.com>

Thanks,

		Amit