From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US6uz-0005KN-1j for qemu-devel@nongnu.org; Tue, 16 Apr 2013 10:31:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1US6B6-0000WC-A9 for qemu-devel@nongnu.org; Tue, 16 Apr 2013 09:44:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US6B6-0000W1-2B for qemu-devel@nongnu.org; Tue, 16 Apr 2013 09:44:08 -0400 Date: Tue, 16 Apr 2013 15:19:30 +0200 From: Kevin Wolf Message-ID: <20130416131930.GA19758@dhcp-200-207.str.redhat.com> References: <1365851501-3037-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1365851501-3037-2-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1365851501-3037-2-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V2 1/5] block: package preparation code in qmp_transaction() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, dietmar@proxmox.com, stefanha@gmail.com Am 13.04.2013 um 13:11 hat Wenchao Xia geschrieben: > The code before really committing is moved into a function. Most This line seems to be indented accidentally? > code are simply moved from qmp_transaction()i, except fail handling > label is changed from "delete_and_fail" to "fail". Other code such > as input parsing is not touched, to make it easier in review. > > Signed-off-by: Wenchao Xia > --- > blockdev.c | 146 +++++++++++++++++++++++++++++++++-------------------------- > 1 files changed, 82 insertions(+), 64 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index 8a1652b..e01906c 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -785,6 +785,84 @@ typedef struct BlkTransactionStates { > QSIMPLEQ_ENTRY(BlkTransactionStates) entry; > } BlkTransactionStates; > > +static int external_snapshot_prepare(const char *device, > + const char *format, > + const char *new_image_file, > + enum NewImageMode mode, > + BlkTransactionStates *states, > + Error **errp) One error reporting mechanism is enough, so this function should return void. Kevin