From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US6vA-00075y-G4 for qemu-devel@nongnu.org; Tue, 16 Apr 2013 10:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1US6hk-0003cf-Cq for qemu-devel@nongnu.org; Tue, 16 Apr 2013 10:17:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US6hk-0003bH-3v for qemu-devel@nongnu.org; Tue, 16 Apr 2013 10:17:52 -0400 Date: Tue, 16 Apr 2013 16:17:49 +0200 From: Igor Mammedov Message-ID: <20130416161749.58f64aa4@nial.usersys.redhat.com> In-Reply-To: <1366053940-9401-2-git-send-email-ehabkost@redhat.com> References: <1366053940-9401-1-git-send-email-ehabkost@redhat.com> <1366053940-9401-2-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qom-cpu PATCH 1/7] target-i386: Move cpuid_xlevel, cpuid_xlevel2 fields in X86CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Andreas =?ISO-8859-1?B?RuRyYmVy?= On Mon, 15 Apr 2013 16:25:34 -0300 Eduardo Habkost wrote: > As the cpuid_*_features fields will be replaced by an array, put the > level/xlevel/xlevel2 fields together in the struct, as they won't be > close to the corresponding cpuid_*_features fields anymore. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > index cf1b05c..500fe93 100644 > --- a/target-i386/cpu.h > +++ b/target-i386/cpu.h > @@ -835,19 +835,19 @@ typedef struct CPUX86State { > > /* processor features (e.g. for CPUID insn) */ > uint32_t cpuid_level; > + uint32_t cpuid_xlevel; > + uint32_t cpuid_xlevel2; > uint32_t cpuid_vendor1; > uint32_t cpuid_vendor2; > uint32_t cpuid_vendor3; > uint32_t cpuid_version; > uint32_t cpuid_features; > uint32_t cpuid_ext_features; > - uint32_t cpuid_xlevel; > uint32_t cpuid_model[12]; > uint32_t cpuid_ext2_features; > uint32_t cpuid_ext3_features; > uint32_t cpuid_apic_id; > /* Store the results of Centaur's CPUID instructions */ > - uint32_t cpuid_xlevel2; > uint32_t cpuid_ext4_features; > /* Flags from CPUID[EAX=7,ECX=0].EBX */ > uint32_t cpuid_7_0_ebx_features; Reviewed-By: Igor Mammedov