From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42017)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1US7I7-0002E7-FV
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 10:55:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1US773-0005q7-Oo
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 10:44:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38225)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1US6ms-0006MI-Gu
	for qemu-devel@nongnu.org; Tue, 16 Apr 2013 10:23:10 -0400
Date: Tue, 16 Apr 2013 16:23:07 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20130416162307.446ccd20@nial.usersys.redhat.com>
In-Reply-To: <1366053940-9401-3-git-send-email-ehabkost@redhat.com>
References: <1366053940-9401-1-git-send-email-ehabkost@redhat.com>
	<1366053940-9401-3-git-send-email-ehabkost@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [qom-cpu PATCH 2/7] target-i386/kvm.c: Code
	formatting changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Mon, 15 Apr 2013 16:25:35 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> Add appropriate spaces around operators, and break line where it needs
> to be broken to allow feature-words array to be introduced without
> having too-long lines.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/kvm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 397afeb..375219a 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -610,7 +610,8 @@ int kvm_arch_init_vcpu(CPUState *cs)
>      cpuid_data.cpuid.nent = cpuid_i;
>  
>      if (((env->cpuid_version >> 8)&0xF) >= 6
> -        && (env->cpuid_features&(CPUID_MCE|CPUID_MCA)) ==
> (CPUID_MCE|CPUID_MCA)
> +        && (env->cpuid_features & (CPUID_MCE|CPUID_MCA)) ==
> +            (CPUID_MCE|CPUID_MCA)
small nit,     ^ perhaps better to align it along with statement above
  
>          && kvm_check_extension(cs->kvm_state, KVM_CAP_MCE) > 0) {
>          uint64_t mcg_cap;
>          int banks;

Reviewed-By: Igor Mammedov <imammedo@redhat.com>