qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [qom-cpu PATCH 4/7] target-i386/cpu.c: Break lines on kvm_cpu_fill_host()
Date: Tue, 16 Apr 2013 17:18:08 +0200	[thread overview]
Message-ID: <20130416171808.7134ef56@nial.usersys.redhat.com> (raw)
In-Reply-To: <1366053940-9401-5-git-send-email-ehabkost@redhat.com>

On Mon, 15 Apr 2013 16:25:37 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> Break lines so they don't get too long once the *_features fields are
> replaced by an array.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 732cafd..5390ca5 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -918,8 +918,10 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
>      x86_cpu_def->stepping = eax & 0x0F;
>  
>      x86_cpu_def->level = kvm_arch_get_supported_cpuid(s, 0x0, 0, R_EAX);
> -    x86_cpu_def->features = kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX);
> -    x86_cpu_def->ext_features = kvm_arch_get_supported_cpuid(s, 0x1, 0,
> R_ECX);
> +    x86_cpu_def->features =
> +        kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX);
> +    x86_cpu_def->ext_features =
> +        kvm_arch_get_supported_cpuid(s, 0x1, 0, R_ECX);
>  
>      if (x86_cpu_def->level >= 7) {
>          x86_cpu_def->cpuid_7_0_ebx_features =

Reviewed 4-6/7 patches, they look good, I'd though would merge them since
they are doing the same repetitive thing and easy to review.

  reply	other threads:[~2013-04-16 15:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 19:25 [Qemu-devel] [qom-cpu PATCH 0/7] replace cpuid_*features fields with a featue word array (v8) Eduardo Habkost
2013-04-15 19:25 ` [Qemu-devel] [qom-cpu PATCH 1/7] target-i386: Move cpuid_xlevel, cpuid_xlevel2 fields in X86CPU Eduardo Habkost
2013-04-16 14:17   ` Igor Mammedov
2013-04-15 19:25 ` [Qemu-devel] [qom-cpu PATCH 2/7] target-i386/kvm.c: Code formatting changes Eduardo Habkost
2013-04-16 14:23   ` Igor Mammedov
2013-04-16 14:35     ` Eduardo Habkost
2013-04-15 19:25 ` [Qemu-devel] [qom-cpu PATCH 3/7] target-i386: Move xlevel/xlevel2 in struct x86_def_t Eduardo Habkost
2013-04-16 14:32   ` Igor Mammedov
2013-04-16 14:41     ` Eduardo Habkost
2013-04-15 19:25 ` [Qemu-devel] [qom-cpu PATCH 4/7] target-i386/cpu.c: Break lines on kvm_cpu_fill_host() Eduardo Habkost
2013-04-16 15:18   ` Igor Mammedov [this message]
2013-04-16 15:43     ` Eduardo Habkost
2013-04-15 19:25 ` [Qemu-devel] [qom-cpu PATCH 5/7] target-i386/cpu.c: Break lines on kvm_check_features_against_host() Eduardo Habkost
2013-04-15 19:25 ` [Qemu-devel] [qom-cpu PATCH 6/7] target-i386/cpu.c: Break lines on builtin_x86_defs array Eduardo Habkost
2013-04-15 19:25 ` [Qemu-devel] [qom-cpu PATCH 7/7] target-i386: Replace cpuid_*features fields with a feature word array Eduardo Habkost
2013-04-16 15:45   ` Igor Mammedov
2013-04-16 15:51 ` [Qemu-devel] [qom-cpu PATCH 0/7] replace cpuid_*features fields with a featue word array (v8) Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130416171808.7134ef56@nial.usersys.redhat.com \
    --to=imammedo@redhat.com \
    --cc=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).