* [Qemu-devel] [PATCH] qemu-iotests: send 'rbd rm ...' stderr to /dev/null
@ 2013-04-16 22:01 Sage Weil
2013-04-17 8:40 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Sage Weil @ 2013-04-16 22:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Sage Weil
The rbd cli tool now sends progress info to stderr; send that to the bit
bucket too.
Signed-off-by: Sage Weil <sage@inktank.com>
---
tests/qemu-iotests/common.rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index a536bf7..d7b0ad1 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -152,7 +152,7 @@ _cleanup_test_img()
;;
rbd)
- rbd rm $TEST_DIR/t.$IMGFMT > /dev/null
+ rbd rm $TEST_DIR/t.$IMGFMT > /dev/null 2> /dev/null
;;
sheepdog)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-iotests: send 'rbd rm ...' stderr to /dev/null
2013-04-16 22:01 [Qemu-devel] [PATCH] qemu-iotests: send 'rbd rm ...' stderr to /dev/null Sage Weil
@ 2013-04-17 8:40 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-04-17 8:40 UTC (permalink / raw)
To: Sage Weil; +Cc: qemu-devel
On Tue, Apr 16, 2013 at 03:01:14PM -0700, Sage Weil wrote:
> The rbd cli tool now sends progress info to stderr; send that to the bit
> bucket too.
>
> Signed-off-by: Sage Weil <sage@inktank.com>
> ---
> tests/qemu-iotests/common.rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Can you add a --quiet or --no-progress option to the rbd cli?
The QEMU patch is simple and could be applied, but rbd cli's approach
prevents users from receiving legitimate error messages when they don't
want verbose progress output. IMO that should be fixed instead.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-17 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-16 22:01 [Qemu-devel] [PATCH] qemu-iotests: send 'rbd rm ...' stderr to /dev/null Sage Weil
2013-04-17 8:40 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).