From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USjQy-0005J2-IM for qemu-devel@nongnu.org; Thu, 18 Apr 2013 03:39:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USjQx-0003Kp-79 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 03:39:08 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:51771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USjQw-0003Kh-W5 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 03:39:07 -0400 Received: by mail-wi0-f181.google.com with SMTP id c10so1382150wiw.14 for ; Thu, 18 Apr 2013 00:39:06 -0700 (PDT) Date: Thu, 18 Apr 2013 09:39:03 +0200 From: Stefan Hajnoczi Message-ID: <20130418073903.GD19195@stefanha-thinkpad.redhat.com> References: <20130418070855.GA6942@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130418070855.GA6942@localhost.localdomain> Subject: Re: [Qemu-devel] qemu-iotests 042: zero size image on VMDK List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Kevin Wolf On Thu, Apr 18, 2013 at 03:08:55PM +0800, Fam Zheng wrote: > Currently VMDK block driver fails qemu-iotest case 042 because it > refuses to create block with zero size (silently). Is support for zero > size image desired or should this case be skipped? > > $ qemu-img create -f vmdk t.vmdk 0 > Formatting 't.vmdk', fmt=vmdk size=0 compat6=off > qemu-img: t.vmdk: error while creating vmdk: No such file or directory Is there a reason to refuse 0-sized images? The VMware tools can resize images so it would be possible to grow them later (i.e. the use case is weird but might still be valid). It's also worth checking if VMware tools allow you to create 0-sized image and whether they can operate on them. If they fail to open or inspect 0-sized images, then QEMU should not create them. Stefan