From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USkeb-0000Tj-Uk for qemu-devel@nongnu.org; Thu, 18 Apr 2013 04:57:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USkeY-0006BN-0F for qemu-devel@nongnu.org; Thu, 18 Apr 2013 04:57:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USkeX-0006BG-Og for qemu-devel@nongnu.org; Thu, 18 Apr 2013 04:57:13 -0400 Date: Thu, 18 Apr 2013 10:58:29 +0300 From: "Michael S. Tsirkin" Message-ID: <20130418075828.GA15869@redhat.com> References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366240040-10730-9-git-send-email-mrhines@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366240040-10730-9-git-send-email-mrhines@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com The following comment applies to all of this code: On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhines@linux.vnet.ibm.com wrote: > diff --git a/migration-rdma.c b/migration-rdma.c > new file mode 100644 > index 0000000..1dff06f > --- /dev/null > +++ b/migration-rdma.c > @@ -0,0 +1,2667 @@ > +/* > + * Copyright (C) 2013 Michael R. Hines > + * Copyright (C) 2010 Jiuxing Liu By the way do you both really hold copyrights on this code? It's not assigned to IBM? If the later it should say: Copyright IBM Author: Michael R. Hines Or some such. > + * > + * RDMA protocol and interfaces > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; under version 2 of the License. We prefer 2 or later for new code. I'm guessing you need approval from Jiuxing Liu for this, pls make him ack license change. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see . > + */