From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49698)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1USkEk-0008Dn-89
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 04:30:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1USkEj-0005ZC-7m
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 04:30:34 -0400
Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:34147)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1USkEj-0005Z6-1W
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 04:30:33 -0400
Received: by mail-wi0-f178.google.com with SMTP id hq17so2546838wib.5
	for <qemu-devel@nongnu.org>; Thu, 18 Apr 2013 01:30:32 -0700 (PDT)
Date: Thu, 18 Apr 2013 10:30:29 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130418083029.GA19587@stefanha-thinkpad.redhat.com>
References: <1365581513-3475-1-git-send-email-wdongxu@linux.vnet.ibm.com>
	<1365581513-3475-2-git-send-email-wdongxu@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1365581513-3475-2-git-send-email-wdongxu@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V18 1/6] docs: document for add-cow file
 format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: kwol@redhat.com, wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Apr 10, 2013 at 04:11:48PM +0800, Dong Xu Wang wrote:
> +The Header is included in the first bytes:
> +(HEADER_SIZE is defined in 40-43 bytes.)
> +    Byte    0  -  3:    magic
> +                        add-cow magic string ("ACOW").
> +
> +            4  -  7:    backing file name offset
> +                        Offset in the add-cow file at which the backing
> +                        file name is stored (NB: The string is not
> +                        lNUL-terminated).

s/lNUL/NUL/

> +            24 - 31:    features
> +                        Bitmask of features. If a feature bit is set
> +                        but not recognized, the add-cow file should be
> +                        dropped. They are not used in now.

"If a feature bit is set but not recognized, the opening the add-cow file must fail.  No features bits are currently defined."