From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USmhB-0006Ef-Vm for qemu-devel@nongnu.org; Thu, 18 Apr 2013 07:08:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USmh6-0001bq-2h for qemu-devel@nongnu.org; Thu, 18 Apr 2013 07:08:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USmh5-0001bd-R2 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 07:08:00 -0400 Date: Thu, 18 Apr 2013 14:07:56 +0300 From: Gleb Natapov Message-ID: <20130418110756.GT8997@redhat.com> References: <1B4B44D9196EFF41AE41FDA404FC0A10C96B9B@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1B4B44D9196EFF41AE41FDA404FC0A10C96B9B@SHSMSX101.ccr.corp.intel.com> Subject: Re: [Qemu-devel] [PATCH] target-i386: upgrade family number of qemu64 CPU model to 15 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Ren, Yongjie" Cc: Marcelo Tosatti , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , ehabkost@redhat.com On Thu, Apr 18, 2013 at 10:45:38AM +0000, Ren, Yongjie wrote: > qemu64 is the default CPU model for QEMU/KVM on x86-64, but its family number > definition is not accurate. The vendor of 'qemu64' is defined as 'AMD'. For AMD > processors, AMD K8 (i.e. Family 15) firstly introduced SSE3 instruction set. > 'qemu64' already has 'CPUID_EXT_SSE3' in its ext_features, but its family > number is only 6 which is not equal to or greater than 15. > So, upgrade the CPU family number of qemu64 model to 15. > After this upgrade, 32bit Windows 8 can boot up with qemu64 CPU model. > This upgrade can be also a fix to the below bug about 32bit Windows 8 booting. > https://bugs.launchpad.net/qemu/+bug/1007269 Changing cpuid info is not that simple since this is guest visible information and can impact migration. Old machine models should still expose the old family. > > Signed-off-by: Yongjie Ren > --- > target-i386/cpu.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index e2302d8..3f8e6c3 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -420,7 +420,7 @@ static x86_def_t builtin_x86_defs[] = { > .name = "qemu64", > .level = 4, > .vendor = CPUID_VENDOR_AMD, > - .family = 6, > + .family = 15, > .model = 2, > .stepping = 3, > .features = PPRO_FEATURES | > -- > 1.7.1 -- Gleb.