From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USmi5-00071L-P5 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 07:09:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USmi4-0001jf-8s for qemu-devel@nongnu.org; Thu, 18 Apr 2013 07:09:01 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:61090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USmi4-0001jZ-2I for qemu-devel@nongnu.org; Thu, 18 Apr 2013 07:09:00 -0400 Received: by mail-ee0-f43.google.com with SMTP id e50so1242256eek.16 for ; Thu, 18 Apr 2013 04:08:59 -0700 (PDT) Date: Thu, 18 Apr 2013 13:08:54 +0200 From: "Edgar E. Iglesias" Message-ID: <20130418110854.GH4915@smtp.vpn> References: <20130418102619.GG4915@smtp.vpn> <516FD2D1.1060403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <516FD2D1.1060403@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 0/3] DTC as submodule List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org, aliguori@us.ibm.com On Thu, Apr 18, 2013 at 01:02:41PM +0200, Paolo Bonzini wrote: > Il 18/04/2013 12:26, Edgar E. Iglesias ha scritto: > > On Thu, Apr 18, 2013 at 02:45:35PM +1000, peter.crosthwaite@xilinx.com wrote: > >> From: Peter Crosthwaite > >> > >> These two patches add and use dtc as a submodule as per the RFC: > >> > >> http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05000.html > >> > >> There is a remaining action item to mandate libfdt for arm/microblaze and PPC > >> which is left as follow up work for after review of this series. > >> > >> Also fixed the configure to properly build pixman when cross compiling. > >> > >> changed since v4: > >> Use error_exit in configure > >> changed since v3: > >> Rebase against recent configure devls. > >> changed since v2: > >> Fixed P1 implementation (PMM review) > >> Fixed CC/AR/LD quoting issue P3 (PMM review) > >> Addressed PMM review > >> changed since v1: > >> Fixed cross compilation of submodules (new P1) > >> Fixed passing of ARFLAGS to dtc submake > > > > > > > > Acked-by: Edgar E. Iglesias > > Great, please apply! > > > CC: Anthony and Bonzini > > > > Shouldn't we in scripts/make_release have a stage that walks the submodules > > and makes sure to bootstrap autoconf so that we package release-tarballs > > with pre-generated configure scripts? > > IIUC, that is standard practice for autoconf tarball releases but I might > > be wrong. > > It depends. Some autoconfiscated packages put autoconf-generated > scripts in the repository. In this case, there is no need to regenerate > the files when brewing the release. Others leave out all such files > (including for example Bison-generated parsers); in this case of course > you need to include the scripts in the tarball, the user is not supposed > to run autoconf himself. OK, thanks. > > For submodules that do have autoconf-generated scripts in the repository > (I think both of them do, in our case), we should trust upstream's > configure script. That's what everyone has been testing the git > repository with. I downloaded the qemu-1.4.1 release and looked at the pixman subdir. It doesnt come with a generated configure script, but has a autogen.sh script to run autoconf itself. My understanding was that, like you say, the user shouldn't need to run autoconf to generate configure, it should have been provided. Am I missing something? Best regards, Edgar