From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USn5V-0000BY-FU for qemu-devel@nongnu.org; Thu, 18 Apr 2013 07:33:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USn5U-0001L0-8G for qemu-devel@nongnu.org; Thu, 18 Apr 2013 07:33:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USn5U-0001Kw-0F for qemu-devel@nongnu.org; Thu, 18 Apr 2013 07:33:12 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3IBXBRt018878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Apr 2013 07:33:11 -0400 Date: Thu, 18 Apr 2013 13:33:09 +0200 From: Kevin Wolf Message-ID: <20130418113309.GB2723@dhcp-200-207.str.redhat.com> References: <1366277029-17311-1-git-send-email-kwolf@redhat.com> <516FCE5A.20103@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <516FCE5A.20103@redhat.com> Subject: Re: [Qemu-devel] [PATCH] savevm: Improve error message for unmigratable devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: qemu-devel@nongnu.org Am 18.04.2013 um 12:43 hat Pavel Hrdina geschrieben: > On 18.4.2013 11:23, Kevin Wolf wrote: > >Trying to take an internal snapshot when an unmigratable device is in > >use resuled in an 'Error -22 while writing VM' message. This patch > >changes it to print the same error message as migration would print: > >'State blocked by non-migratable device xyz' > > > >Signed-off-by: Kevin Wolf > >--- > > Hi Kevin, > > this patch is not needed because I'm fixing the same in my patch > series > http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg03287.html > in this patch > http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg03298.html Okay, I wasn't CCed on that series, so I wasn't fully aware of what it's touching or not. I'll comment on your series. Kevin