From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1USw4D-0003Pn-Lg
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 17:08:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1USw4C-0000Do-LO
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 17:08:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8334)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rjones@redhat.com>) id 1USw4C-0000Dk-ES
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 17:08:28 -0400
Date: Thu, 18 Apr 2013 22:08:25 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
Message-ID: <20130418210825.GY4272@rhmail.home.annexia.org>
References: <1366316465-32710-1-git-send-email-sw@weilnetz.de>
	<51705AA1.5030300@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51705AA1.5030300@weilnetz.de>
Subject: Re: [Qemu-devel] block/ssh: Compilation fails on Debian squeeze
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Thu, Apr 18, 2013 at 10:42:09PM +0200, Stefan Weil wrote:
> Am 18.04.2013 22:21, schrieb Stefan Weil:
> > Now gcc will check whether format string and variable arguments match.
> >
> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> > ---
> >
> > Please note: I could only run limited tests with the new code
> > because ssh.c is currently not compiled in my w32/w64 environment.
> >
> > Regards,
> > Stefan W.
> 
> The test fails on current Debian (squeeze), not because of wrong
> format specifiers, but because of an "old" libssh2-1-dev.
> 
> ssh.c calls libssh2_session_handshake which was added in 1.2.8,
> see http://www.libssh2.org/libssh2_session_handshake.html.
> 
> Can we simplify the libssh2 check in configure and require
> pkg-config, no compile check?

Sounds fine to me.  Did you mean you want me to provide a patch?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/