From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT67C-0005PK-HX for qemu-devel@nongnu.org; Fri, 19 Apr 2013 03:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UT679-0002Vl-Id for qemu-devel@nongnu.org; Fri, 19 Apr 2013 03:52:14 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:52562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT679-0002VG-D3 for qemu-devel@nongnu.org; Fri, 19 Apr 2013 03:52:11 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Apr 2013 01:52:04 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 32B571FF003C for ; Fri, 19 Apr 2013 01:46:59 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3J7q02F360704 for ; Fri, 19 Apr 2013 01:52:00 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3J7q0gv030635 for ; Fri, 19 Apr 2013 01:52:00 -0600 Date: Fri, 19 Apr 2013 09:51:58 +0200 From: Jens Freimann Message-ID: <20130419075158.GC14662@linux.vnet.ibm.com> References: <1364971345-3110-1-git-send-email-jfrei@linux.vnet.ibm.com> <516EE4AD.3090508@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <516EE4AD.3090508@suse.de> Subject: Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Eduardo Habkost , qemu-devel , Alexander Graf , Christian Borntraeger , Cornelia Huck , Igor Mammedov On Wed, Apr 17, 2013 at 08:06:37PM +0200, Andreas Färber wrote: > Hi Jens, > > Am 03.04.2013 08:42, schrieb Jens Freimann: > > this is what our approach to CPU hotplug looks like. > > With respect to Igor's CPU hotplug series, how should we proceed? > > Should we change the interface to > > qemu_system_cpu_add_notifier/qemu_system_cpu_hotplug_request/cpu-add etc? > > I am wondering if my recent qdev/device_add fixes would allow to > implement CPU hot-add via device_add for s390x? >>From what I've seen so far it could be possible, but... > Background is that for x86 we currently have a flat CPU core/thread > namespace but would need to deal with sockets, cores and threads to get > topologies right. I assume there are no such issues on s390x, so that > the vCPU to CPUState mapping could stay 1:1? s390 hardware today already has a topology and CPU features. We are not modelling it in QEMU right now, but want to go there in the future so that there would be no simple 1:1 mapping anymore. > > Feedback regarding the non-API part is also highly welcome! > > I did spot some QOM'ish nitpicks in the qdev_create() but I am wondering > if you and Alex see an urgent need to get this into 1.5 during the Soft > Freeze or whether we can just align it to x86 work for now and deal with > it after the release? We'll try to have it ready as soon as possible but I think it's unlikely for 1.5. Getting started with Igor's review feedback right now and looking at qdev_create() as well. Regards, Jens > Regards, > Andreas > > > Thang Pham (1): > > s390: implement CPU hotplug > > > > hmp-commands.hx | 14 +++++ > > hw/s390x/Makefile.objs | 2 +- > > hw/s390x/event-facility.c | 9 ++++ > > hw/s390x/event-facility.h | 3 ++ > > hw/s390x/s390-virtio.c | 34 +++++++++--- > > hw/s390x/sclp.c | 134 +++++++++++++++++++++++++++++++++++++++++++++- > > hw/s390x/sclp.h | 47 +++++++++++++++- > > include/sysemu/sysemu.h | 1 + > > monitor.c | 31 +++++++++++ > > target-s390x/cpu.c | 59 ++++++++++++++++++++ > > target-s390x/cpu.h | 7 +++ > > target-s390x/helper.c | 43 +++++++++++++++ > > vl.c | 6 +++ > > 13 files changed, 379 insertions(+), 11 deletions(-) > > > > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >