From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35607)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UT7G5-0008DQ-Au
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 05:05:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UT7G4-0003H8-1U
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 05:05:29 -0400
Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:48723)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UT7G3-0003H1-SR
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 05:05:27 -0400
Received: by mail-wi0-f177.google.com with SMTP id hj19so467523wib.16
	for <qemu-devel@nongnu.org>; Fri, 19 Apr 2013 02:05:27 -0700 (PDT)
Date: Fri, 19 Apr 2013 11:05:24 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130419090524.GB28732@stefanha-thinkpad.redhat.com>
References: <1366343325-5252-1-git-send-email-famz@redhat.com>
	<1366343325-5252-4-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1366343325-5252-4-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] vmdk: Add option to create
 zeroed-grain image
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Feiran Zheng <feiran.zheng@emc.com>

On Fri, Apr 19, 2013 at 11:48:43AM +0800, Fam Zheng wrote:
> @@ -1714,6 +1719,11 @@ static QEMUOptionParameter vmdk_create_options[] = {
>              "VMDK flat extent format, can be one of "
>              "{monolithicSparse (default) | monolithicFlat | twoGbMaxExtentSparse | twoGbMaxExtentFlat | streamOptimized} "
>      },
> +    {
> +        .name = BLOCK_OPT_ZEROED_GRAIN,

This option should be #defined in this patch.

> +        .type = OPT_FLAG,
> +        .help = "Enable zeroed-grain featur (implies header.version = 2)"

This message doesn't help the user.  Maybe something like this?

"Enable efficient zero writes using the zeroed-grain GTE feature"

I think header.version = 2 isn't relevant to users.  People who care
will have read the VMDK specification already.