From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UT7HM-0000x3-Cl
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 05:06:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UT7HL-0003mu-4t
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 05:06:48 -0400
Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:37369)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UT7HK-0003mo-VT
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 05:06:47 -0400
Received: by mail-wi0-f179.google.com with SMTP id l13so471466wie.6
	for <qemu-devel@nongnu.org>; Fri, 19 Apr 2013 02:06:46 -0700 (PDT)
Date: Fri, 19 Apr 2013 11:06:43 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130419090643.GC28732@stefanha-thinkpad.redhat.com>
References: <1366343325-5252-1-git-send-email-famz@redhat.com>
	<1366343325-5252-5-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1366343325-5252-5-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/5] vmdk: change magic number to macro
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Feiran Zheng <feiran.zheng@emc.com>

On Fri, Apr 19, 2013 at 11:48:44AM +0800, Fam Zheng wrote:
> From: Feiran Zheng <feiran.zheng@emc.com>
> 
> Two hard coded flag bits are changed to macros.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/vmdk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 827b35b..5daa9f2 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -32,6 +32,7 @@
>  #define VMDK3_MAGIC (('C' << 24) | ('O' << 16) | ('W' << 8) | 'D')
>  #define VMDK4_MAGIC (('K' << 24) | ('D' << 16) | ('M' << 8) | 'V')
>  #define VMDK4_COMPRESSION_DEFLATE 1
> +#define VMDK4_FLAG_NL_DETECT (1 << 0)
>  #define VMDK4_FLAG_RGD (1 << 1)
>  /* Zeroed-grain enable bit */
>  #define VMDK4_FLAG_ZG   (1 << 2)
> @@ -1285,7 +1286,7 @@ static int vmdk_create_extent(const char *filename, int64_t filesize,
>      magic = cpu_to_be32(VMDK4_MAGIC);
>      memset(&header, 0, sizeof(header));
>      header.version = zeroed_grain ? 2 : 1;
> -    header.flags = 3
> +    header.flags = VMDK4_FLAG_RGD | VMDK4_FLAG_NL_DETECT

Nice :)