From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT7NP-000394-OX for qemu-devel@nongnu.org; Fri, 19 Apr 2013 05:13:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UT7NL-0005aN-7i for qemu-devel@nongnu.org; Fri, 19 Apr 2013 05:13:03 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:52238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT7NL-0005aF-1I for qemu-devel@nongnu.org; Fri, 19 Apr 2013 05:12:59 -0400 Received: by mail-wi0-f172.google.com with SMTP id hq17so479372wib.5 for ; Fri, 19 Apr 2013 02:12:58 -0700 (PDT) Date: Fri, 19 Apr 2013 11:12:55 +0200 From: Stefan Hajnoczi Message-ID: <20130419091255.GD28732@stefanha-thinkpad.redhat.com> References: <1366343325-5252-1-git-send-email-famz@redhat.com> <1366343325-5252-6-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366343325-5252-6-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/5] vmdk: add bdrv_co_write_zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Feiran Zheng On Fri, Apr 19, 2013 at 11:48:45AM +0800, Fam Zheng wrote: > From: Feiran Zheng > > Use special offset to write zeroes efficiently, when zeroed-grain GTE is > available. If zero-write an allocated cluster, cluster is leaked because > its offset pointer is overwritten by "0x1". > > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++------------- > 1 file changed, 50 insertions(+), 13 deletions(-) Do existing qemu-iotests zero write tests cases cover this? Do you need to add vmdk to their list of supported formats? Stefan