[Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

[Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

[Petar Jovanovic]

From: Petar Jovanovic <petar.jovanovic@imgtec.com>

do_semop() is called from two places, and one of these fails to convert
return error to target errno when semop fails. This patch changes the
function to always return target errno in case of an unsuccessful call.

Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
---
 linux-user/syscall.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index ee82a2d..3c4c155 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2764,7 +2764,7 @@ static inline abi_long do_semop(int semid, abi_long ptr, unsigned nsops)
     if (target_to_host_sembuf(sops, ptr, nsops))
         return -TARGET_EFAULT;
 
-    return semop(semid, sops, nsops);
+    return get_errno(semop(semid, sops, nsops));
 }
 
 struct target_msqid_ds
@@ -6957,7 +6957,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
 #endif
 #ifdef TARGET_NR_semop
     case TARGET_NR_semop:
-        ret = get_errno(do_semop(arg1, arg2, arg3));
+        ret = do_semop(arg1, arg2, arg3);
         break;
 #endif
 #ifdef TARGET_NR_semctl
-- 
1.7.9.5

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

[Peter Maydell]

On 21 March 2013 17:57, Petar Jovanovic <petar.jovanovic@rt-rk.com> wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> do_semop() is called from two places, and one of these fails to convert
> return error to target errno when semop fails. This patch changes the
> function to always return target errno in case of an unsuccessful call.
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

[Petar Jovanovic]

ping

http://patchwork.ozlabs.org/patch/229787/

________________________________________
From: Peter Maydell [peter.maydell@linaro.org]
Sent: Thursday, March 21, 2013 7:03 PM
To: Petar Jovanovic
Cc: qemu-devel@nongnu.org; riku.voipio@linaro.org; Petar Jovanovic
Subject: Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

On 21 March 2013 17:57, Petar Jovanovic <petar.jovanovic@rt-rk.com> wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> do_semop() is called from two places, and one of these fails to convert
> return error to target errno when semop fails. This patch changes the
> function to always return target errno in case of an unsuccessful call.
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

[Petar Jovanovic]

ping
________________________________________
From: Petar Jovanovic
Sent: Monday, April 01, 2013 7:07 PM
To: Peter Maydell; Petar Jovanovic
Cc: qemu-devel@nongnu.org; riku.voipio@linaro.org
Subject: RE: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

ping

http://patchwork.ozlabs.org/patch/229787/

________________________________________
From: Peter Maydell [peter.maydell@linaro.org]
Sent: Thursday, March 21, 2013 7:03 PM
To: Petar Jovanovic
Cc: qemu-devel@nongnu.org; riku.voipio@linaro.org; Petar Jovanovic
Subject: Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

On 21 March 2013 17:57, Petar Jovanovic <petar.jovanovic@rt-rk.com> wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> do_semop() is called from two places, and one of these fails to convert
> return error to target errno when semop fails. This patch changes the
> function to always return target errno in case of an unsuccessful call.
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

[Petar Jovanovic]

+ qemu-trivial@nongnu.org

ping
________________________________________
From: Petar Jovanovic
Sent: Monday, April 08, 2013 8:31 PM
To: Peter Maydell; Petar Jovanovic
Cc: qemu-devel@nongnu.org; riku.voipio@linaro.org
Subject: RE: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

ping
________________________________________
From: Petar Jovanovic
Sent: Monday, April 01, 2013 7:07 PM
To: Peter Maydell; Petar Jovanovic
Cc: qemu-devel@nongnu.org; riku.voipio@linaro.org
Subject: RE: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

ping

http://patchwork.ozlabs.org/patch/229787/

________________________________________
From: Peter Maydell [peter.maydell@linaro.org]
Sent: Thursday, March 21, 2013 7:03 PM
To: Petar Jovanovic
Cc: qemu-devel@nongnu.org; riku.voipio@linaro.org; Petar Jovanovic
Subject: Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

On 21 March 2013 17:57, Petar Jovanovic <petar.jovanovic@rt-rk.com> wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> do_semop() is called from two places, and one of these fails to convert
> return error to target errno when semop fails. This patch changes the
> function to always return target errno in case of an unsuccessful call.
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

[Stefan Hajnoczi]

On Thu, Mar 21, 2013 at 06:57:36PM +0100, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
> 
> do_semop() is called from two places, and one of these fails to convert
> return error to target errno when semop fails. This patch changes the
> function to always return target errno in case of an unsuccessful call.
> 
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
>  linux-user/syscall.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

[Riku Voipio]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

On 19 April 2013 12:42, Stefan Hajnoczi <stefanha@gmail.com> wrote:

> On Thu, Mar 21, 2013 at 06:57:36PM +0100, Petar Jovanovic wrote:
> > From: Petar Jovanovic <petar.jovanovic@imgtec.com>
> >
> > do_semop() is called from two places, and one of these fails to convert
> > return error to target errno when semop fails. This patch changes the
> > function to always return target errno in case of an unsuccessful call.
> >
> > Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> > ---
> >  linux-user/syscall.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Thanks, applied to the trivial patches tree:
> https://github.com/stefanha/qemu/commits/trivial-patches
>
> Hi,

It's also in my linux-user updates set I'm testing now:

https://git.linaro.org/gitweb?p=people/rikuvoipio/qemu.git;a=shortlog;h=refs/heads/linux-user-for-upstream

[-- Attachment #2: Type: text/html, Size: 1698 bytes --]