From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT97O-0007EB-GK for qemu-devel@nongnu.org; Fri, 19 Apr 2013 07:04:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UT97I-0001h1-Bn for qemu-devel@nongnu.org; Fri, 19 Apr 2013 07:04:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UT97I-0001gv-4e for qemu-devel@nongnu.org; Fri, 19 Apr 2013 07:04:32 -0400 Date: Fri, 19 Apr 2013 19:04:27 +0800 From: Fam Zheng Message-ID: <20130419110427.GA25716@localhost.localdomain> References: <1366343325-5252-1-git-send-email-famz@redhat.com> <1366343325-5252-6-git-send-email-famz@redhat.com> <20130419091255.GD28732@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130419091255.GD28732@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/5] vmdk: add bdrv_co_write_zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, Feiran Zheng On Fri, 04/19 11:12, Stefan Hajnoczi wrote: > On Fri, Apr 19, 2013 at 11:48:45AM +0800, Fam Zheng wrote: > > From: Feiran Zheng > > > > Use special offset to write zeroes efficiently, when zeroed-grain GTE is > > available. If zero-write an allocated cluster, cluster is leaked because > > its offset pointer is overwritten by "0x1". > > > > Signed-off-by: Fam Zheng > > --- > > block/vmdk.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++------------- > > 1 file changed, 50 insertions(+), 13 deletions(-) > > Do existing qemu-iotests zero write tests cases cover this? Do you need > to add vmdk to their list of supported formats? I guess they cover and has include vmdk already, need to double check correctness of both side and fix the multiple extents cases (twoGbMaxExtent{Sparse,Flat}). This patch can't properly handle metadata update for zero write, will fix in next version. -- Fam